Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 音声が一切鳴らなくなる可能性がある #12491

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Nov 28, 2023

What

#12433 (comment)

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4e5b776) 78.68% compared to head (9e21e1d) 78.64%.
Report is 1 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/scripts/sound.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12491      +/-   ##
===========================================
- Coverage    78.68%   78.64%   -0.05%     
===========================================
  Files          951      949       -2     
  Lines       103427   103236     -191     
  Branches      8329     8329              
===========================================
- Hits         81385    81193     -192     
- Misses       22042    22043       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12 anatawa12 changed the title chore: 音声が一切鳴らなくなる可能性を軽減 fix: 音声が一切鳴らなくなる可能性がある Nov 28, 2023
@syuilo syuilo merged commit 4e88241 into misskey-dev:develop Nov 29, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 29, 2023

🙏

@anatawa12 anatawa12 deleted the play-file-error-proof branch November 29, 2023 01:33
anatawa12 added a commit to anatawa12/misskey that referenced this pull request Nov 29, 2023
* chore: 音声が一切鳴らなくなる可能性を軽減

misskey-dev#12433 (comment)

* chore: IIFEではなくPromise.prototype.finallyを使用するように
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* chore: 音声が一切鳴らなくなる可能性を軽減

misskey-dev#12433 (comment)

* chore: IIFEではなくPromise.prototype.finallyを使用するように
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants