Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): GHSA-3f39-6537-3cgc について追記 #12482

Merged
merged 1 commit into from
Nov 27, 2023
Merged

docs(changelog): GHSA-3f39-6537-3cgc について追記 #12482

merged 1 commit into from
Nov 27, 2023

Conversation

KisaragiEffective
Copy link
Collaborator

What

GHSA-3f39-6537-3cgc について追記

Why

  • CVSSスコアが高いものにもかかわらずリリースノートに言及がないため
  • 一般にGitHub Security Advisoryはリリースノートよりも見る人が少ないため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d0253b) 78.66% compared to head (a28dac1) 78.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12482      +/-   ##
===========================================
- Coverage    78.66%   78.30%   -0.36%     
===========================================
  Files          950      178     -772     
  Lines       103300    23636   -79664     
  Branches      8329      496    -7833     
===========================================
- Hits         81257    18509   -62748     
+ Misses       22043     5127   -16916     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih merged commit d58ec4e into misskey-dev:develop Nov 27, 2023
15 checks passed
kakkokari-gtyih added a commit that referenced this pull request Nov 27, 2023
kakkokari-gtyih added a commit that referenced this pull request Nov 27, 2023
…2483)

* Revert "docs(changelog): GHSA-3f39-6537-3cgc について追記 (#12482)"

This reverts commit d58ec4e.

* Update CHANGELOG.md
kakkokari-gtyih added a commit to misskey-dev/misskey-hub that referenced this pull request Nov 27, 2023
kakkokari-gtyih added a commit to misskey-dev/misskey-hub-next that referenced this pull request Nov 27, 2023
@kakkokari-gtyih
Copy link
Contributor

パッチが当たったのは v2023.11.1 でした(#12483 で対応しておきました)🙏🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
…12482)" (misskey-dev#12483)

* Revert "docs(changelog): GHSA-3f39-6537-3cgc について追記 (misskey-dev#12482)"

This reverts commit d58ec4e.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants