Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix a frontend testing script #12471

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Nov 26, 2023

What

$ pnpm --filter frontend run testを実行すると次のエラーが出るので修正します:

Error: You are using vitest without globals, this way we can't run cleanup after each test.
See https://testing-library.com/docs/vue-testing-library/setup for details or set the VTL_SKIP_AUTO_CLEANUP variable to 'true'

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (780b120) 78.72% compared to head (a0b2389) 78.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12471      +/-   ##
===========================================
- Coverage    78.72%   78.71%   -0.02%     
===========================================
  Files          951      950       -1     
  Lines       103311   103247      -64     
  Branches      8301     8301              
===========================================
- Hits         81332    81268      -64     
  Misses       21979    21979              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 01d06e7 into misskey-dev:develop Nov 26, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

🙏

@woxtu woxtu deleted the testing branch November 27, 2023 03:00
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants