Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): 何もノートしていないユーザーのフィードにアクセスするとエラーになる問題を修正 #12455

Merged

Conversation

zyoshoka
Copy link
Contributor

@zyoshoka zyoshoka commented Nov 25, 2023

What

何もノートしていないユーザーのフィードにアクセスした際に発生するエラーを修正しました。

Why

Fix: #12454

Additional info (optional)

何もノートしていないユーザーのフィードを GET できるかどうか確認するテストを追加します。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95095ee) 78.74% compared to head (8be38bb) 78.73%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12455      +/-   ##
===========================================
- Coverage    78.74%   78.73%   -0.01%     
===========================================
  Files          947      947              
  Lines       102905   102905              
  Branches      8292     8297       +5     
===========================================
- Hits         81028    81027       -1     
- Misses       21877    21878       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 25, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 3e0231d into misskey-dev:develop Nov 26, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

🙏🙏

anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Nov 26, 2023
* fix(backend): 何もノートしていないユーザーのフィードにアクセスするとエラーになる問題を修正

* Update CHANGELOG.md

* add test

* fix: incorrect bob's username
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* fix(backend): 何もノートしていないユーザーのフィードにアクセスするとエラーになる問題を修正

* Update CHANGELOG.md

* add test

* fix: incorrect bob's username
@zyoshoka zyoshoka deleted the return-empty-feed-if-user-has-no-notes branch May 15, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

何もノートしていないユーザーのフィードにアクセスすると 500 が返ってくる
2 participants