Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): リアクション選択時に音を流せるように #12441

Merged
merged 6 commits into from
Nov 26, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

タイトル通り

Why

#11915 を部分的に実装(バイブレーションはまたこんど)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d32631d) 78.74% compared to head (fa0c181) 78.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12441      +/-   ##
===========================================
- Coverage    78.74%   78.57%   -0.17%     
===========================================
  Files          177      177              
  Lines        23485    23478       -7     
  Branches       496      496              
===========================================
- Hits         18494    18449      -45     
- Misses        4991     5029      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

先に #12457 をマージ

@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

音作るか

@syuilo syuilo merged commit 5bdae9f into misskey-dev:develop Nov 26, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

👍👍

@kakkokari-gtyih kakkokari-gtyih deleted the enh-11915 branch December 8, 2023 06:35
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* (add) リアクション選択時に音を鳴らせるように

* Update Changelog

* tweak sound

* tweak sound

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants