Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query error in notes/featured #12439

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

anatawa12
Copy link
Member

What

#12438

Why

Fix #12438

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9c84055) 78.76% compared to head (e4fd66f) 78.84%.
Report is 4 commits behind head on develop.

Files Patch % Lines
...backend/src/server/api/endpoints/notes/featured.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12439      +/-   ##
===========================================
+ Coverage    78.76%   78.84%   +0.07%     
===========================================
  Files          948      947       -1     
  Lines       103024   102905     -119     
  Branches      8290     8318      +28     
===========================================
- Hits         81149    81133      -16     
+ Misses       21875    21772     -103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit d32631d into misskey-dev:develop Nov 26, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

🙏

@anatawa12 anatawa12 deleted the fix-featured-query-error branch November 26, 2023 03:54
anatawa12 added a commit to anatawa12/misskey that referenced this pull request Nov 26, 2023
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
2 participants