Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): Replace deprecated Repository.findOneById() #12426

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Nov 24, 2023

What

TypeORMの非推奨なRepository.findOneById()findOneBy()に置き換えます。

Why

Repository and EntityManager method .findOneById is deprecated and will be removed in next 0.3.0 version. Use findOne(id) method instead now.

https://github.com/typeorm/typeorm/blob/d184d8598c057ce8fa54815e669b567238f3a86e/CHANGELOG.md#020

とのこと。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06ed64f) 78.77% compared to head (692a116) 93.92%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #12426       +/-   ##
============================================
+ Coverage    78.77%   93.92%   +15.14%     
============================================
  Files          949        2      -947     
  Lines       103088      461   -102627     
  Branches      8289       59     -8230     
============================================
- Hits         81211      433    -80778     
+ Misses       21877       28    -21849     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit f7bdf5a into misskey-dev:develop Nov 24, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 24, 2023

🙏

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@woxtu woxtu deleted the find-one branch November 24, 2023 00:50
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants