絵文字詳細ページに記載する情報を追加 #12417
Merged
絵文字詳細ページに記載する情報を追加 #12417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12417 +/- ##
===========================================
+ Coverage 78.34% 78.45% +0.11%
===========================================
Files 179 180 +1
Lines 23680 23807 +127
Branches 496 496
===========================================
+ Hits 18551 18678 +127
Misses 5129 5129 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
|
それだけ大量の情報が出るならalertではなくmodalなどで実装したほうがいいかもしれない |
|
現状よりは良さそうなのでマージ |
|
🙏 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* Update emojis.emoji.vue * Update CHANGELOG.md --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
表題の通り
Why
apiで多くの情報が取得できているのにも関わらず、現状では表示されるのがライセンスのみであるため。
Additional info (optional)
翻訳の必要性は低いと考え、取得した値をそのまま表示させています。
Checklist