Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twitterの埋め込みカード内リンクからリンク先を開けない問題を修正 #12400

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

eai04191
Copy link
Contributor

What

  • twitter埋め込みカード内のsandbox属性にallow-popups-to-escape-sandboxを追加

Why

To fix #12291

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 21, 2023
@eai04191 eai04191 changed the title fix: twitterの埋め込みカード内のリンクを開けない問題を修正 fix: twitterの埋め込みカード内リンクからリンク先を開けない問題を修正 Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b13179) 78.81% compared to head (89e2af8) 78.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12400      +/-   ##
===========================================
+ Coverage    78.81%   78.89%   +0.08%     
===========================================
  Files          949      773     -176     
  Lines       102919    79876   -23043     
  Branches      8278     7841     -437     
===========================================
- Hits         81111    63016   -18095     
+ Misses       21808    16860    -4948     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit c6ed06d into misskey-dev:develop Nov 22, 2023
16 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 22, 2023

🙏

@eai04191 eai04191 deleted the fix-twitter-embed branch November 22, 2023 04:42
@syuilo
Copy link
Member

syuilo commented Dec 22, 2023

CHANGELOG必要そう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
2 participants