Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-schema/note.tsの定義が足りていなかったのを修正 #12395

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

samunohito
Copy link
Member

What

#12312 で取り切れなかった型エラーを修正しました。

Why

pnpm --filter backend run typecheckでエラーになるため

Additional info (optional)

pnpm --filter backend run typecheckを実行してエラーにならないことを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 21, 2023
@samunohito samunohito mentioned this pull request Nov 21, 2023
5 tasks
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77ac51a) 78.77% compared to head (fe1fb54) 78.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12395      +/-   ##
===========================================
- Coverage    78.77%   78.63%   -0.15%     
===========================================
  Files          947      176     -771     
  Lines       102721    23334   -79387     
  Branches      8274      495    -7779     
===========================================
- Hits         80921    18349   -62572     
+ Misses       21800     4985   -16815     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit b5be0e5 into misskey-dev:develop Nov 21, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 21, 2023

🙏🙏🙏

@samunohito samunohito deleted the fix/update-jsonschema3 branch January 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants