通知音などの発音方法を変え、iOSで音声出力が競合しないようにする #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12339 +/- ##
===========================================
- Coverage 78.84% 78.74% -0.10%
===========================================
Files 946 176 -770
Lines 102153 23296 -78857
Branches 8255 495 -7760
===========================================
- Hits 80544 18345 -62199
+ Misses 21609 4951 -16658 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
samunohito
changed the title
samunohito
changed the title
|
🙏🏻 🙏🏻 🙏🏻 🙏🏻 |
Merged
|
Androidでも改善してます👍👍👍👍 |
|
Androidでも改善してるなら元issue閉じちゃって平気かしら |
|
（WebAudio経由での発音になったおかげで、副作用で通知などへのサウンドのレスポンスも良くなってる） |
|
ただ、複数の通知が同時に入った場合に多重で通知音が鳴って音割れしそう |
n1lsqn
pushed a commit
to n1lsqn/misskey
that referenced
this pull request
Nov 15, 2023
* HTMLAudioElementを使わないようにする * fix CHANGELOG.md --------- Co-authored-by: osamu <[email protected]>
|
oh hell yeah. thank you for this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#12340 の対応です。
この対応により、iOSでバックグラウンド再生中の音楽がMisskeyの通知音などを受けて停止してしまう現象が改善されます。
Why
詳細は #12340 をご参照願います
Additional info (optional)
プルリクを出しているブランチをみすてむずに乗せてもらい、実動作確認済みです。
Checklist