入力フォームでもリアクション選択時に使用するピッカーを使うようにしたい #12337
Merged
+84
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12337 +/- ##
===========================================
+ Coverage 78.42% 78.75% +0.33%
===========================================
Files 180 954 +774
Lines 23857 103809 +79952
Branches 495 8353 +7858
===========================================
+ Hits 18709 81752 +63043
- Misses 5148 22057 +16909 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
samunohito
changed the title
syuilo
reviewed
Nov 15, 2023
| @@ -124,6 +124,7 @@ import { deepClone } from '@/scripts/clone.js'; | |||
| import MkRippleEffect from '@/components/MkRippleEffect.vue'; | |||
| import { miLocalStorage } from '@/local-storage.js'; | |||
| import { claimAchievement } from '@/scripts/achievements.js'; | |||
| import { reactionPicker } from '@/scripts/reaction-picker.js'; | |||
There was a problem hiding this comment.
|
ついでに絵文字ピッカーにリアクションデッキとして設定した絵文字が表示されるのも直すか |
|
👍🏻 👍🏻 |
This was referenced Dec 3, 2023
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* 入力フォームでもリアクション選択時に使用するピッカーを使うようにしたい * erase console.log * fix CHANGELOG.md * reaction-picker.ts を戻し、今回の対応を入れた emoji-picker.ts を新たに作成 * fix CHANGELOG.md * tweak --------- Co-authored-by: osamu <[email protected]> Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#12336 の対応です。
この対応により、投稿フォームの絵文字ピッカーがノートにリアクションをつける時のリアクションピッカーと同じものになります（詳細はissueにて）
Why
詳細は #12336 にて
Additional info (optional)
Checklist