Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): Implementation of HTTP header and body validation to fix SIF-2023-002 #12334

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

sinoru
Copy link
Contributor

@sinoru sinoru commented Nov 14, 2023

What

Enhances implementation of HTTP header and body validation to fix SIF-2023-002
SIF-2023-002を修正するため、HTTPヘッダーおよびボディー検証実装機能を向上させます。

Why

This will uses Buffer instead of string on HTTP header and body validation for performance.
パフォーマンスのために、HTTPヘッダーおよびボディー検証に文字列の代わりにバッファを使用します。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 14, 2023
@sinoru sinoru force-pushed the feature/SIF-2023-002 branch from b9648fe to e8e1954 Compare November 14, 2023 15:48
Copy link
Contributor

github-actions bot commented Nov 14, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@sinoru sinoru force-pushed the feature/SIF-2023-002 branch from e8e1954 to 81c56e0 Compare November 14, 2023 16:00
@sinoru sinoru marked this pull request as ready for review November 14, 2023 16:00
…o fix SIF-2023-002

Using Buffer instead of string

Co-authored-by: perillamint <[email protected]>
@sinoru sinoru force-pushed the feature/SIF-2023-002 branch from 81c56e0 to 9f71654 Compare November 14, 2023 16:02
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d2906d4) 78.80% compared to head (9f71654) 78.77%.

Files Patch % Lines
...ges/backend/src/server/ActivityPubServerService.ts 26.08% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12334      +/-   ##
===========================================
- Coverage    78.80%   78.77%   -0.03%     
===========================================
  Files          945      945              
  Lines       102013   102033      +20     
  Branches      8242     8239       -3     
===========================================
- Hits         80390    80381       -9     
- Misses       21623    21652      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perillamint
Copy link
Contributor

This also improves compatibility between (potential) non-utf8 POST requests.
これはまた、utf8でない(可能性のある)POSTリクエスト間の互換性を向上させます。

@kakkokari-gtyih kakkokari-gtyih added the 🔒Security Security related issue/PR label Nov 14, 2023
@syuilo syuilo merged commit 04075ee into misskey-dev:develop Nov 15, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 15, 2023

👍🏻 👍🏻 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR 🔒Security Security related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants