Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ref化したnoteの変更通知がMfmコンポーネントまで到達してないのを修正 #12282

Conversation

samunohito
Copy link
Member

What

#12281 の対応です。
プラグイン側で加工したノートの内容が反映されないバグが修正されます。

Why

プラグイン側で加工したノートが反映されず、プラグインの意味をなさなくなってしまうため

Additional info (optional)

実際にissueのプラグインをインストール&設定し、プラグインが期待動作することを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (828749b) 78.82% compared to head (db7e34e) 78.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12282      +/-   ##
===========================================
+ Coverage    78.82%   78.87%   +0.04%     
===========================================
  Files          944      946       +2     
  Lines       101894   102064     +170     
  Branches      8233     8237       +4     
===========================================
+ Hits         80323    80500     +177     
+ Misses       21571    21564       -7     
Files Coverage Δ
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 879f2d2 into misskey-dev:develop Nov 9, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 9, 2023

🙏

@samunohito samunohito deleted the fix/12281_not_working_plugin_interruptor branch January 11, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants