Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 投稿通知がオンでもダイレクト投稿はユーザーに通知されないように #12263

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

GrapeApple0
Copy link
Contributor

投稿者
screenshot 933
受信設定者
screenshot 934

What

投稿通知がオンでもダイレクト投稿はユーザーに通知されないようにしました。

Why

fix: #12262

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b02f724) 78.85% compared to head (983595c) 78.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12263      +/-   ##
===========================================
- Coverage    78.85%   78.83%   -0.03%     
===========================================
  Files          945      944       -1     
  Lines       102000   101896     -104     
  Branches      8238     8235       -3     
===========================================
- Hits         80434    80327     -107     
- Misses       21566    21569       +3     
Files Coverage Δ
packages/backend/src/core/NoteCreateService.ts 90.46% <28.57%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 28e394e into misskey-dev:develop Nov 9, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 9, 2023

🙏

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 9, 2023
* fix: 投稿通知がオンでもダイレクト投稿はユーザーに通知されないように

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ユーザーの投稿通知をオンにすると閲覧権限のない投稿まで通知が来る
3 participants