Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): federated instance icon with proxy (welcome entrance) #12213

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

caipira113
Copy link
Contributor

@caipira113 caipira113 commented Nov 1, 2023

What

Proxy the federated instance icon that appears on the welcome entrance.

Why

  1. Loading a URL directly can expose the user's request data to the other server.
  2. It will depend on your environment, but in severe cases it will increase the time of all other requests. ▼
image image

Additional info (optional)

None.

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd0b6c1) 78.93% compared to head (61ebec6) 78.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12213      +/-   ##
===========================================
+ Coverage    78.93%   78.95%   +0.02%     
===========================================
  Files          943      944       +1     
  Lines       101446   101552     +106     
  Branches      8237     8236       -1     
===========================================
+ Hits         80073    80177     +104     
- Misses       21373    21375       +2     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 470a1c3 into misskey-dev:develop Nov 3, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 3, 2023

🙏🏻

@caipira113 caipira113 deleted the proxied-icon branch November 3, 2023 10:52
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants