Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 絵文字ピッカーでバッテリーの絵文字が複数表示される問題を修正 #12212

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

Srgr0
Copy link
Collaborator

@Srgr0 Srgr0 commented Nov 1, 2023

What

名称が重複している絵文字(battery)の名称変更

Why

fix #12197

Additional info (optional)

事象確認済み

  • misskey.io (13.14.2-io.13a)
  • misskey.srgr0.com (2023.10.2)

改善確認済み

  • mkexp.srgr0.com (2023.11.0-beta.7 + this fix)
    @ srgr0 @ misskey.srgr0.comにDMしていただければログイン情報お渡しします。
    docker_hubのsrgr0/misskey:developが変更適用済みイメージです。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a73f7c) 79.14% compared to head (3727340) 79.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12212      +/-   ##
===========================================
+ Coverage    79.14%   79.15%   +0.01%     
===========================================
  Files          942      943       +1     
  Lines       101028   101134     +106     
  Branches      8221     8218       -3     
===========================================
+ Hits         79956    80052      +96     
- Misses       21072    21082      +10     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@Srgr0 Srgr0 changed the title fix #12197 fix 絵文字ピッカーでバッテリーの絵文字が複数表示される問題を修正 Nov 1, 2023
@Srgr0 Srgr0 marked this pull request as ready for review November 2, 2023 10:07
@syuilo syuilo merged commit f1903b2 into misskey-dev:develop Nov 2, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 2, 2023

🙏🏻

@Srgr0 Srgr0 deleted the fix-12197 branch November 2, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

バッテリーの絵文字が増殖する(2023.11.0-beta.6)
2 participants