Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): 自身の宛先なしダイレクト投稿がストリーミングで流れてこない問題を修正 #12203

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

slofp
Copy link
Contributor

@slofp slofp commented Oct 31, 2023

What

今まで自身の宛先がないダイレクト投稿がストリーミングできて、おそらく 3f4ee98 からできなくなっているのでその修正。

Why

fixed #12193

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6e5bf1) 79.28% compared to head (72ccda3) 79.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12203      +/-   ##
===========================================
- Coverage    79.28%   79.16%   -0.12%     
===========================================
  Files          944      944              
  Lines       101182   101182              
  Branches      8253     8214      -39     
===========================================
- Hits         80218    80097     -121     
- Misses       20964    21085     +121     
Files Coverage Δ
...nd/src/server/api/stream/channels/home-timeline.ts 89.07% <100.00%> (ø)
.../src/server/api/stream/channels/hybrid-timeline.ts 90.57% <100.00%> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo
Copy link
Member

syuilo commented Oct 31, 2023

2023.10.2で発生していないのであればCHANGELOGは不要かも

@slofp
Copy link
Contributor Author

slofp commented Oct 31, 2023

2023.10.2で発生していないのであればCHANGELOGは不要かも

ちょっと見てみます

@slofp
Copy link
Contributor Author

slofp commented Oct 31, 2023

2023.10.2で発生していないのであればCHANGELOGは不要かも

ちょっと見てみます

2023.10.2の時点で発生していた。

streamDMPR1

@syuilo
Copy link
Member

syuilo commented Oct 31, 2023

3f4ee98 が2023.10.2以降のコミットだと勘違いしてた
ありがとうございます 🙏🏻

@syuilo syuilo merged commit 7c69228 into misskey-dev:develop Oct 31, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

宛先なしDMを投稿した際、TLが更新されない
2 participants