Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: headerActionにPC以外で空のボタンが出てしまうバグの修正 #12202

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

fruitriin
Copy link
Contributor

@fruitriin fruitriin commented Oct 31, 2023

What

スクリーンショット 2023-10-31 13 19 11
スクリーンショット 2023-10-31 13 19 15
引張りリロードとデスクトップ用の更新ボタンが配置されましたが、この更新ボタンはデスクトップ以外では空白として存在します。(配列にからのオブジェクトとして存在しているので)
これを削除します

スクリーンショット 2023-10-31 13 30 16

Why

スクリーンサイズの小さいスマートフォンでは、ヘッダーの謎の空白はより気になります

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6e5bf1) 79.28% compared to head (21dae2e) 79.13%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12202      +/-   ##
===========================================
- Coverage    79.28%   79.13%   -0.15%     
===========================================
  Files          944      942       -2     
  Lines       101182   101012     -170     
  Branches      8253     8221      -32     
===========================================
- Hits         80218    79935     -283     
- Misses       20964    21077     +113     

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fruitriin fruitriin changed the title headerActionにPC以外で空のボタンが出てしまうバグの修正 fix: headerActionにPC以外で空のボタンが出てしまうバグの修正 Oct 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo
Copy link
Member

syuilo commented Oct 31, 2023

セミコロン、クォートなどコードスタイルを他の個所と合わせていただけると 🙏🏻

@fruitriin
Copy link
Contributor Author

👍

@syuilo syuilo merged commit e2f34e3 into misskey-dev:develop Oct 31, 2023
16 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 31, 2023

👍

@fruitriin fruitriin deleted the fix/smartphone-emptybutton branch October 31, 2023 09:26
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
* headerActionにPC以外で空のボタンが出てしまうバグの修正

* fix eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants