Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: プラグイン削除時にアクセストークンも削除する #12167

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

書いてある通り

バックエンドの変更点

  • API i/revoke-token で生トークンを使って削除できるようにしました

Why

Fix #12067

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (8a2309b) 79.22% compared to head (bc509cf) 79.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12167      +/-   ##
===========================================
- Coverage    79.22%   79.18%   -0.05%     
===========================================
  Files          942      940       -2     
  Lines       100948   100793     -155     
  Branches      8218     8215       -3     
===========================================
- Hits         79977    79810     -167     
- Misses       20971    20983      +12     
Files Coverage Δ
...backend/src/server/api/endpoints/i/revoke-token.ts 64.91% <22.72%> (-13.66%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih changed the title (enhance) プラグイン削除時にアクセストークンも削除する enhance: プラグイン削除時にアクセストークンも削除する Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit e5ff8d8 into misskey-dev:develop Oct 27, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 27, 2023

👍👍👍

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
* (enhance) プラグイン削除時にトークンも削除

* update changelog
@kakkokari-gtyih kakkokari-gtyih deleted the enh-12067 branch December 8, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

プラグインのアンインストール時に使用していたアクセストークンを削除する
2 participants