Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkGoogleのクエリを正しくエンコードできるように修正 #12164

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

タイトル通り

Why

Fix #11996

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5ff8d8) 79.15% compared to head (19897a3) 79.21%.
Report is 2 commits behind head on develop.

❗ Current head 19897a3 differs from pull request most recent head 52822aa. Consider uploading reports for the commit 52822aa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12164      +/-   ##
===========================================
+ Coverage    79.15%   79.21%   +0.06%     
===========================================
  Files          177      941     +764     
  Lines        23007   100886   +77879     
  Branches       491     8216    +7725     
===========================================
+ Hits         18211    79917   +61706     
- Misses        4796    20969   +16173     
Files Coverage Δ
packages/frontend/src/components/MkGoogle.vue 100.00% <100.00%> (ø)

... and 766 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit aa31b6c into misskey-dev:develop Oct 27, 2023
3 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 27, 2023

🙏

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
* (fix)MkGoogleで一部キーワードのURLエンコードに失敗する

* Update Changelog

---------

Co-authored-by: syuilo <[email protected]>
@kakkokari-gtyih kakkokari-gtyih deleted the fix-11996 branch December 8, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

「#」を含むgoogle検索が出来ない
2 participants