Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): ハッシュタグのランキングの問い合わせ結果がないときのエラー修正 #12145

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Oct 25, 2023

What

resultがないときにundefinedになりlengthが取得できないエラーが起きるので配列になるように直した

Why

fix: #12144

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d9b5ae) 79.20% compared to head (7ce7ddf) 78.99%.
Report is 2 commits behind head on develop.

❗ Current head 7ce7ddf differs from pull request most recent head ecfe471. Consider uploading reports for the commit ecfe471 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12145      +/-   ##
===========================================
- Coverage    79.20%   78.99%   -0.22%     
===========================================
  Files          939      175     -764     
  Lines       100686    22837   -77849     
  Branches      8203      491    -7712     
===========================================
- Hits         79753    18041   -61712     
+ Misses       20933     4796   -16137     

see 764 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@tai-cha tai-cha marked this pull request as ready for review October 26, 2023 11:23
@syuilo syuilo merged commit 8a2309b into misskey-dev:develop Oct 27, 2023
12 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 27, 2023

🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Error on hashtags/trend
2 participants