feat: AiScriptでホストのアドレスを参照できる定数 #11924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11924 +/- ##
===========================================
+ Coverage 78.92% 78.95% +0.02%
===========================================
Files 928 929 +1
Lines 99088 99174 +86
Branches 7882 7884 +2
===========================================
+ Hits 78204 78299 +95
+ Misses 20884 20875 -9 ☔ View full report in Codecov by Sentry. |
|
SERVER_URLの方が良いかも(hostだとURL内のhost部分と混同されそう) |
Merged
syuilo
added a commit
that referenced
this pull request
Sep 30, 2023
* fix(backend): Redisに古いMisskeyバージョンのキャッシュが残っている場合の問題を修正 * Update CHANGELOG.md * enhance(front)end: improve moderation log * enhance: ノートの翻訳機能の利用可否をロールで設定可能に Resolve #11923 * 2023.9.3 * 後方互換性の強化 * Update CHANGELOG.md * fix test * [ci skip] New Crowdin updates (#11922) * New translations ja-jp.yml (German) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (English) * New translations ja-jp.yml (German) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Thai) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Chinese Simplified) * feat: AiScriptでホストのアドレスを参照できる定数 (#11924) * add HOST_URL * Update CHANGELOG.md * tweak --------- Co-authored-by: syuilo <[email protected]> --------- Co-authored-by: FineArchs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
AiScriptでホストのアドレスを参照できる定数
HOST_URLを追加します。Why
ノートやPlay等のIDからURLを形成するなどのケースで、あると便利なため。
Additional info (optional)
Checklist