Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(i18n): 翻訳ファイルのd.ts生成をbuild-assetsスクリプト内で実行する #11812

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

上の通り

Why

翻訳だけ更新した際に、型定義ファイルの更新のためだけにviteを再起動する必要があり不便だったため

この変更により、翻訳ファイルを更新した際は以下のコマンドを叩けば各所に反映されるようになる

$ pnpm build-assets

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 10, 2023
@kakkokari-gtyih kakkokari-gtyih changed the title (refactor)i18n: 翻訳ファイルのd.ts生成をbuild-assetsスクリプト内で実行する refactor(i18n): 翻訳ファイルのd.ts生成をbuild-assetsスクリプト内で実行する Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15% 🎉

Comparison is base (c0838c4) 78.69% compared to head (eba45be) 78.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11812      +/-   ##
===========================================
+ Coverage    78.69%   78.85%   +0.15%     
===========================================
  Files          174      176       +2     
  Lines        22796    22965     +169     
  Branches       511      511              
===========================================
+ Hits         17940    18109     +169     
  Misses        4856     4856              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 7bd0a5b into misskey-dev:develop Sep 10, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 10, 2023

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the i18n-dts branch September 10, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants