Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #11764

Merged
merged 35 commits into from
Sep 4, 2023
Merged

update deps #11764

merged 35 commits into from
Sep 4, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Aug 27, 2023

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/sw and PWA ServiceWorker and PWA related issue/PR packages/misskey-js labels Aug 27, 2023
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 92.26% and project coverage change: -0.05% ⚠️

Comparison is base (2db63d1) 78.68% compared to head (d25b3f9) 78.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11764      +/-   ##
===========================================
- Coverage    78.68%   78.64%   -0.05%     
===========================================
  Files          925      923       -2     
  Lines        97670    97509     -161     
  Branches      7750     7739      -11     
===========================================
- Hits         76852    76682     -170     
- Misses       20818    20827       +9     
Files Changed Coverage Δ
packages/frontend/src/os.ts 17.50% <0.00%> (-0.14%) ⬇️
packages/frontend/src/scripts/get-note-menu.ts 5.11% <14.28%> (ø)
packages/frontend/src/account.ts 13.96% <33.33%> (ø)
packages/frontend/src/scripts/use-note-capture.ts 9.73% <50.00%> (ø)
packages/frontend/src/scripts/select-file.ts 20.00% <85.71%> (ø)
packages/backend/src/core/MetaService.ts 93.43% <100.00%> (ø)
...s/backend/src/core/chart/ChartManagementService.ts 91.46% <100.00%> (ø)
packages/backend/src/daemons/JanitorService.ts 78.00% <100.00%> (ø)
packages/backend/src/daemons/QueueStatsService.ts 46.46% <100.00%> (ø)
packages/backend/src/daemons/ServerStatsService.ts 46.01% <100.00%> (ø)
... and 36 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member Author

syuilo commented Aug 28, 2023

image
tasukete

@syuilo
Copy link
Member Author

syuilo commented Aug 28, 2023

moduleResokutionがnode16の場合はmoduleもnode16にしないと怒られるため、moduleをesnextなどにすることはできない

@syuilo
Copy link
Member Author

syuilo commented Sep 1, 2023

おごごごご

@syuilo
Copy link
Member Author

syuilo commented Sep 1, 2023

moduleResolutionをnodenextにすればいい可能性

@syuilo
Copy link
Member Author

syuilo commented Sep 1, 2023

おあー

> tsc -p .storybook && node .storybook/generate.js && node .storybook/preload-locale.js && node .storybook/preload-theme.js

error TS2688: Cannot find type definition file for 'testing-library__jest-dom'.
  The file is in the program because:
    Entry point for implicit type library 'testing-library__jest-dom'
 ELIFECYCLE  Command failed with exit code 2.

@syuilo

This comment was marked as resolved.

@syuilo
Copy link
Member Author

syuilo commented Sep 1, 2023

別にjson importにこだわる必要ないか

@syuilo
Copy link
Member Author

syuilo commented Sep 1, 2023

ヌァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァンンンンオオオオンンオンオンオンオンンンンンンンンン゛ン゛!!!!!!!!!!!!!!!!

@u1-liquid
Copy link
Contributor

FYI: MisskeyIO#148

@syuilo
Copy link
Member Author

syuilo commented Sep 1, 2023

うーむ
image

@syuilo
Copy link
Member Author

syuilo commented Sep 2, 2023

ふ  ぬ  ん  も

@syuilo
Copy link
Member Author

syuilo commented Sep 2, 2023

FetchInstanceMetadataServiceのテストが失敗するようになった理由が謎

@syuilo
Copy link
Member Author

syuilo commented Sep 2, 2023

諸々解決された方に報奨金を進呈

@syuilo
Copy link
Member Author

syuilo commented Sep 3, 2023

Storybookに関しては解決できなさそうだから無効にするしかないわね

@syuilo
Copy link
Member Author

syuilo commented Sep 3, 2023

ワークフローファイルごと消さないといけないのか

@syuilo
Copy link
Member Author

syuilo commented Sep 3, 2023

うーむ

@syuilo
Copy link
Member Author

syuilo commented Sep 3, 2023

afterEach / beforeEach ではなく afterAll / beforeEach を使っているからモックがリセットされないのが原因説

@syuilo
Copy link
Member Author

syuilo commented Sep 3, 2023

当たり

@syuilo
Copy link
Member Author

syuilo commented Sep 3, 2023

マージするか

@syuilo
Copy link
Member Author

syuilo commented Sep 3, 2023

afterEach / beforeEach ではなく afterAll / beforeEach を使っているからモックがリセットされないのが原因説

今までなぜ動いてたのか

@syuilo syuilo marked this pull request as ready for review September 3, 2023 23:57
@syuilo syuilo merged commit 1f7a81a into develop Sep 4, 2023
17 of 18 checks passed
@syuilo syuilo deleted the update-deps branch September 4, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js packages/sw and PWA ServiceWorker and PWA related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants