Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): Add address bind config option #11725

Merged
merged 3 commits into from
Aug 20, 2023

Conversation

TheEssem
Copy link
Contributor

What

This adds a new config option, outgoingAddress, which lets the instance admin manually provide an IP address to bind to for outgoing fetch requests.

Why

Fixes #11406, which is caused when deploying Misskey in environments where requests are proxied by creating a new network interface, e.g. when using Wireguard or Tailscale.

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #11725 (3e3ab48) into develop (c3fd848) will decrease coverage by 0.03%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##           develop   #11725      +/-   ##
===========================================
- Coverage    78.75%   78.73%   -0.03%     
===========================================
  Files          923      922       -1     
  Lines        97814    97714     -100     
  Branches      7742     7742              
===========================================
- Hits         77035    76933     -102     
- Misses       20779    20781       +2     
Files Changed Coverage Δ
packages/backend/src/core/HttpRequestService.ts 85.96% <50.00%> (-0.87%) ⬇️
packages/backend/src/config.ts 96.58% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@syuilo syuilo merged commit 3eacbe6 into misskey-dev:develop Aug 20, 2023
16 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 20, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deliver queue increased, failed and cannot deliver to remote server (mostly to Mastodon)
2 participants