Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: word mute is not applied to sub note #11711

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

paring-chan
Copy link
Contributor

What

This makes sub note do the same behavior when note is muted

image

Why

The word note feature is applied only on normal notes, not on sub notes(example: reply target)

Additional info (optional)

None.

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 12, 2023
@github-actions github-actions bot requested review from syuilo and tamaina August 12, 2023 15:17
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #11711 (e3d57e8) into develop (ab58b65) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11711      +/-   ##
===========================================
- Coverage    78.76%   78.73%   -0.04%     
===========================================
  Files          924      922       -2     
  Lines        97856    97709     -147     
  Branches      7741     7741              
===========================================
- Hits         77074    76927     -147     
  Misses       20782    20782              
Files Changed Coverage Δ
packages/frontend/src/components/MkNoteSub.vue 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@syuilo syuilo merged commit c3fd848 into misskey-dev:develop Aug 14, 2023
@syuilo
Copy link
Member

syuilo commented Aug 14, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants