fix: モバイル表示のときページ下部がナビゲーションバーに隠れる問題を修正 #11370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #11370 +/- ##
===========================================
- Coverage 77.71% 77.66% -0.05%
===========================================
Files 920 745 -175
Lines 92734 70976 -21758
Branches 7748 7251 -497
===========================================
- Hits 72064 55125 -16939
+ Misses 20670 15851 -4819 |
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fix: #11317
ページ下部に挿入される余白の高さ
--minBottomSpacingの値を、media queryではなくJSで実際のnavbarの表示と連動させて設定するようにしました。
Why
navbarに隠れて操作できない領域が発生していたため。
Checklist