Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): Use promises API #11351

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jul 22, 2023

What

Promises APIがあるメソッドはそれを使うように変更します。

Why

都度util.promisify()しなくて良くなると嬉しい。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 22, 2023
@github-actions github-actions bot requested review from syuilo and tamaina July 22, 2023 11:56
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #11351 (5c2118f) into develop (b546d41) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop   #11351      +/-   ##
===========================================
- Coverage    77.69%   77.68%   -0.02%     
===========================================
  Files          918      919       +1     
  Lines        92621    92626       +5     
  Branches      7748     7748              
===========================================
- Hits         71966    71955      -11     
- Misses       20655    20671      +16     
Impacted Files Coverage Δ
packages/backend/src/core/DownloadService.ts 70.00% <66.66%> (-0.40%) ⬇️
packages/backend/src/core/FileInfoService.ts 67.60% <100.00%> (-0.31%) ⬇️
packages/backend/src/server/api/ApiCallService.ts 74.87% <100.00%> (-0.19%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います👍

@syuilo syuilo merged commit cb0fa9a into misskey-dev:develop Jul 27, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 27, 2023

👍🏻

@woxtu woxtu deleted the promises branch July 27, 2023 16:47
@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants