Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): better error message for unsupported attestation #11333

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

saschanaz
Copy link
Member

What

#8691 に最低限の対応

Why

せめてなにがunsupportedなのか分かるように

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment (N/A)
  • (If needed) Add story of storybook (N/A)
  • (If needed) Update CHANGELOG.md (N/A)
  • (If possible) Add tests (N/A)

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #11333 (9d0e7d8) into develop (509e3f9) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #11333      +/-   ##
===========================================
+ Coverage    77.68%   77.72%   +0.03%     
===========================================
  Files          917      919       +2     
  Lines        92563    92722     +159     
  Branches      7748     7748              
===========================================
+ Hits         71908    72065     +157     
- Misses       20655    20657       +2     
Impacted Files Coverage Δ
...backend/src/server/api/endpoints/i/2fa/key-done.ts 87.87% <0.00%> (ø)

... and 3 files with indirect coverage changes

@syuilo syuilo merged commit 64c142b into develop Jul 20, 2023
18 checks passed
@syuilo syuilo deleted the 2fa-unsupported branch July 20, 2023 22:49
@syuilo
Copy link
Member

syuilo commented Jul 20, 2023

👍

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants