Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Improve number formatting on MkUserInfo #11315

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jul 18, 2023

What

検索画面などで表示されるユーザー情報の各数字に桁区切りを追加します。
Resolve #11030

image

Why

大きな数字も読みやすくするため。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #11315 (15e46e7) into develop (9d145d3) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11315      +/-   ##
===========================================
- Coverage    77.74%   77.71%   -0.04%     
===========================================
  Files          919      917       -2     
  Lines        92727    92568     -159     
  Branches      7743     7745       +2     
===========================================
- Hits         72089    71935     -154     
+ Misses       20638    20633       -5     

see 4 files with indirect coverage changes

@syuilo syuilo merged commit b0b0ecb into misskey-dev:develop Jul 18, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 18, 2023

👍

@woxtu woxtu deleted the number-format branch July 19, 2023 17:44
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: MkUserInfo で数字の桁区切りが効いてない
3 participants