Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): use nodemon for storybook #11297

Merged
merged 2 commits into from
Jul 20, 2023
Merged

refactor(frontend): use nodemon for storybook #11297

merged 2 commits into from
Jul 20, 2023

Conversation

saschanaz
Copy link
Member

What

chokidarの代わりにnodemonを使う

Why

  1. 簡単(コマンドが)
  2. 簡単(コントリビューションガイドが)(Windowsでも動くので)

Additional info (optional)

pnpm devにも使ったらよさそう

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook (N/A)
  • (If needed) Update CHANGELOG.md (N/A)
  • (If possible) Add tests (N/A)

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #11297 (8759def) into develop (df54806) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11297      +/-   ##
===========================================
- Coverage    77.84%   77.70%   -0.15%     
===========================================
  Files          917      916       -1     
  Lines        92631    92531     -100     
  Branches      7769     7740      -29     
===========================================
- Hits         72112    71899     -213     
- Misses       20519    20632     +113     

see 18 files with indirect coverage changes

@syuilo syuilo merged commit 47b6841 into develop Jul 20, 2023
17 checks passed
@syuilo syuilo deleted the nodemon branch July 20, 2023 08:41
@syuilo
Copy link
Member

syuilo commented Jul 20, 2023

👍🏻

1 similar comment
@syuilo
Copy link
Member

syuilo commented Jul 20, 2023

👍🏻

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* refactor(frontend): use nodemon for storybook

* Update package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants