Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): Use nullish coalescing operator #11294

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jul 16, 2023

What

||??に代えてESLintの@typescript-eslint/prefer-nullish-coalescingルール違反を解決します。

/***/misskey/packages/frontend/src/components/global/MkMisskeyFlavoredMarkdown.ts
  259:123  error    Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator  @typescript-eslint/prefer-nullish-coalescing

Why

エラーが消えると嬉しい。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #11294 (4018ca6) into develop (5453710) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #11294      +/-   ##
===========================================
- Coverage    77.82%   77.70%   -0.13%     
===========================================
  Files          916      916              
  Lines        92525    92525              
  Branches      7768     7739      -29     
===========================================
- Hits         72008    71895     -113     
- Misses       20517    20630     +113     
Impacted Files Coverage Δ
...src/components/global/MkMisskeyFlavoredMarkdown.ts 29.15% <0.00%> (ø)

... and 17 files with indirect coverage changes

@syuilo syuilo merged commit 96cde67 into misskey-dev:develop Jul 16, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 16, 2023

🙏🏻

@woxtu woxtu deleted the nullish-coalescin branch July 18, 2023 14:31
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants