Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): locales/index.d.ts生成時にexport defaultを生成するように #11280

Merged

Conversation

anatawa12
Copy link
Member

What

locales/index.d.ts生成時にexport defaultを生成するように

Why

generateDTS.jsが実行されるたびにdiffが作られる

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 marked this pull request as ready for review July 14, 2023 11:35
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #11280 (eb85f46) into develop (2b6dbd4) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11280      +/-   ##
===========================================
- Coverage    77.71%   77.35%   -0.36%     
===========================================
  Files          171      169       -2     
  Lines        21555    21093     -462     
  Branches       496      437      -59     
===========================================
- Hits         16751    16317     -434     
+ Misses        4804     4776      -28     

see 2 files with indirect coverage changes

@anatawa12
Copy link
Member Author

3c4ddf0export = locales; に変更されてる原因の修正になります

@tamaina tamaina merged commit 1c82e97 into misskey-dev:develop Jul 14, 2023
18 checks passed
@tamaina
Copy link
Contributor

tamaina commented Jul 14, 2023

🙏🙏🙏

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
@anatawa12 anatawa12 deleted the fix-dts-generation-for-locales branch November 24, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants