Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): skip fetching notes when the data is same-origin #11200

Merged
merged 4 commits into from
Jul 8, 2023

Conversation

saschanaz
Copy link
Member

What

#11130 (comment) の実装

Why

同じサーバーから送られたデータを疑う理由はなさそうです

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook (N/A)
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Jul 8, 2023
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #11200 (dbe4d50) into develop (74a05ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #11200   +/-   ##
========================================
  Coverage    77.83%   77.83%           
========================================
  Files          171      171           
  Lines        21517    21517           
  Branches       496      496           
========================================
  Hits         16748    16748           
  Misses        4769     4769           

@saschanaz
Copy link
Member Author

saschanaz commented Jul 8, 2023

storybookなぜ失敗し続けるの #11201

.map(item => limit(() => this.apNoteService.resolveNote(item, {
resolver: _resolver,
sentFrom: new URL(user.uri),
}))));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すごい括弧

@syuilo syuilo merged commit 5059d4d into develop Jul 8, 2023
@syuilo syuilo deleted the fetch-featured branch July 8, 2023 23:59
@syuilo
Copy link
Member

syuilo commented Jul 8, 2023

👍👍

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
…isskey-dev#11200)

* refactor(backend): skip fetching notes when the data is same-origin

* Update CHANGELOG.md

* sentFrom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants