refactor(backend): skip fetching notes when the data is same-origin #11200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
Codecov Report
@@ Coverage Diff @@
## develop #11200 +/- ##
========================================
Coverage 77.83% 77.83%
========================================
Files 171 171
Lines 21517 21517
Branches 496 496
========================================
Hits 16748 16748
Misses 4769 4769 |
|
|
syuilo
reviewed
Jul 8, 2023
| .map(item => limit(() => this.apNoteService.resolveNote(item, { | ||
| resolver: _resolver, | ||
| sentFrom: new URL(user.uri), | ||
| })))); |
|
👍👍 |
This was referenced Jul 9, 2023
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
…isskey-dev#11200) * refactor(backend): skip fetching notes when the data is same-origin * Update CHANGELOG.md * sentFrom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#11130 (comment) の実装
Why
同じサーバーから送られたデータを疑う理由はなさそうです
Additional info (optional)
Checklist