fix(frontend): search user with trailing space #11184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #11184 +/- ##
===========================================
+ Coverage 77.33% 77.96% +0.63%
===========================================
Files 908 173 -735
Lines 91643 21646 -69997
Branches 7545 496 -7049
===========================================
- Hits 70874 16877 -53997
+ Misses 20769 4769 -16000 |
|
API側でもtrimしてあげると良いかも |
|
@syuilo 改善しました |
|
🙏🏻 |
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
* fix(frontend): search user with trailing space * fix(backend): search user with trailing space * Update search.ts --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ユーザー検索する前に
trim()をするWhy
ユーザーを検索する際、末尾に空白があると正常に動作しないことがあります
Additional info (optional)
Checklist