Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: webp convert @frontend #11150

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

Narazaka
Copy link
Contributor

@Narazaka Narazaka commented Jul 7, 2023

What

フロントエンドでの画像圧縮をwebpにする

Safariなど変換非対応ブラウザでは従来のままにする(変換非対応でも読み込みは出来る)

Why

resolves #9370

Additional info (optional)

qualityがこれで良いか(特にwebp->webp変換)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 7, 2023
@github-actions github-actions bot requested review from syuilo and tamaina July 7, 2023 02:56
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #11150 (46651b3) into develop (d5c4e77) will increase coverage by 16.52%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #11150       +/-   ##
============================================
+ Coverage    77.41%   93.93%   +16.52%     
============================================
  Files          909        2      -907     
  Lines        91803      462    -91341     
  Branches      7551       59     -7492     
============================================
- Hits         71067      434    -70633     
+ Misses       20736       28    -20708     

see 907 files with indirect coverage changes

@tamaina
Copy link
Contributor

tamaina commented Jul 7, 2023

pngをwebpにしたくないってゴネた記憶があったけど試したところ特に問題ないのでマージするか

@tamaina tamaina merged commit bc4d274 into misskey-dev:develop Jul 7, 2023
@tamaina
Copy link
Contributor

tamaina commented Jul 7, 2023

👍

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* webp convert @frontend

* 0.85 → 0.90

---------

Co-authored-by: tamaina <[email protected]>
@tamaina
Copy link
Contributor

tamaina commented Aug 5, 2023

やっぱなんとなく品質がよろしくない気がする

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compress PNG to WebP if non-animated and non-transparent
2 participants