Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): ノート削除時のfindCascadingNotesの処理を整理 #11131

Merged
merged 2 commits into from
Jul 6, 2023
Merged

refactor(backend): ノート削除時のfindCascadingNotesの処理を整理 #11131

merged 2 commits into from
Jul 6, 2023

Conversation

okayurisotto
Copy link
Contributor

What

ノートが削除されるときにはそのノートと連なったノートに関しても削除され、削除アクティビティがdeliverされます。このPRでは削除アクティビティをdeliverするために「連なったノート」を探す処理をリファクタリングしました。

Why

現時点では特に何かに困っているわけではありません。強いて挙げるなら、現時点ではPromise.allを使っていないため並列では処理されなくなってしまっていると思われます。が、これによってどういった影響が出ているのかについては不明です。

Additional info (optional)

このPRでリファクタリングしたのは #5812 で追加された処理です。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #11131 (bfec04e) into develop (d2f8ed9) will increase coverage by 0.63%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11131      +/-   ##
===========================================
+ Coverage    77.36%   77.99%   +0.63%     
===========================================
  Files          907      172     -735     
  Lines        91642    21627   -70015     
  Branches      7552      498    -7054     
===========================================
- Hits         70903    16869   -54034     
+ Misses       20739     4758   -15981     

see 739 files with indirect coverage changes

@syuilo syuilo merged commit 4a7da72 into misskey-dev:develop Jul 6, 2023
@syuilo
Copy link
Member

syuilo commented Jul 6, 2023

👍

@okayurisotto okayurisotto deleted the refactor-backend-findcascadingnotes branch July 6, 2023 02:29
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* refactor(backend): ノート削除時の`findCascadingNotes`の処理を整理

* cleanup: unneeded async await

Co-authored-by: syuilo <[email protected]>

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants