refactor(backend): ノート削除時のfindCascadingNotesの処理を整理
#11131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syuilo
reviewed
Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## develop #11131 +/- ##
===========================================
+ Coverage 77.36% 77.99% +0.63%
===========================================
Files 907 172 -735
Lines 91642 21627 -70015
Branches 7552 498 -7054
===========================================
- Hits 70903 16869 -54034
+ Misses 20739 4758 -15981 |
Co-authored-by: syuilo <[email protected]>
|
👍 |
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
* refactor(backend): ノート削除時の`findCascadingNotes`の処理を整理 * cleanup: unneeded async await Co-authored-by: syuilo <[email protected]> --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ノートが削除されるときにはそのノートと連なったノートに関しても削除され、削除アクティビティがdeliverされます。このPRでは削除アクティビティをdeliverするために「連なったノート」を探す処理をリファクタリングしました。
Why
現時点では特に何かに困っているわけではありません。強いて挙げるなら、現時点では
Promise.allを使っていないため並列では処理されなくなってしまっていると思われます。が、これによってどういった影響が出ているのかについては不明です。Additional info (optional)
このPRでリファクタリングしたのは #5812 で追加された処理です。
Checklist