-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): deck UIのカラムからアンテナ、リストの編集画面を開けるように #11104
Merged
syuilo
merged 4 commits into
misskey-dev:develop
from
anatawa12:feat-edit-antenna-from-column-menu
Jul 5, 2023
Merged
feat(frontend): deck UIのカラムからアンテナ、リストの編集画面を開けるように #11104
syuilo
merged 4 commits into
misskey-dev:develop
from
anatawa12:feat-edit-antenna-from-column-menu
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
changed the title
feat: deck UIのカラムからアンテナ、リストの編集画面を開けるように
feat(frontend): deck UIのカラムからアンテナ、リストの編集画面を開けるように
Jul 4, 2023
Codecov Report
@@ Coverage Diff @@
## develop #11104 +/- ##
===========================================
- Coverage 77.48% 77.33% -0.15%
===========================================
Files 909 907 -2
Lines 91645 91486 -159
Branches 7572 7547 -25
===========================================
- Hits 71014 70754 -260
- Misses 20631 20732 +101 |
特に違和感は感じなかった |
マージしたい |
👍 |
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Jul 13, 2023
* feat: add edit antenna button onto deck column * feat: add edit list button onto deck column * docs(changelog): add deck UIのカラムのメニューからアンテナとリストの編集画面を開けるようになりました Cherry-picks: 1ab9f09
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
* feat: add edit antenna button onto deck column * feat: add edit list button onto deck column * docs(changelog): add deck UIのカラムのメニューからアンテナとリストの編集画面を開けるようになりました
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
deckのカラムのドロップダウンからアンテナ、リストの編集画面を開けるようにした
Closes #11095
Why
そこにアンテナがあるのに選択画面に行き、名前を思い出して選択するのが少し使いづらいため
Additional info (optional)
CONTRIBUTING.mdを読むのが実装後だったため、design and policy reviewをもらっていません。
Checklist