Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): deck UIのカラムからアンテナ、リストの編集画面を開けるように #11104

Merged

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Jul 4, 2023

What

deckのカラムのドロップダウンからアンテナ、リストの編集画面を開けるようにした

Closes #11095

Why

そこにアンテナがあるのに選択画面に行き、名前を思い出して選択するのが少し使いづらいため

Additional info (optional)

CONTRIBUTING.mdを読むのが実装後だったため、design and policy reviewをもらっていません。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 4, 2023
@anatawa12 anatawa12 changed the title feat: deck UIのカラムからアンテナ、リストの編集画面を開けるように feat(frontend): deck UIのカラムからアンテナ、リストの編集画面を開けるように Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #11104 (86b881f) into develop (61e7eb8) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11104      +/-   ##
===========================================
- Coverage    77.48%   77.33%   -0.15%     
===========================================
  Files          909      907       -2     
  Lines        91645    91486     -159     
  Branches      7572     7547      -25     
===========================================
- Hits         71014    70754     -260     
- Misses       20631    20732     +101     

see 20 files with indirect coverage changes

@tamaina
Copy link
Contributor

tamaina commented Jul 5, 2023

image

アイコンの並びが微妙な感じがしなくもない

@syuilo
Copy link
Member

syuilo commented Jul 5, 2023

特に違和感は感じなかった

@tamaina
Copy link
Contributor

tamaina commented Jul 5, 2023

マージしたい

@syuilo syuilo merged commit 1ab9f09 into misskey-dev:develop Jul 5, 2023
@syuilo
Copy link
Member

syuilo commented Jul 5, 2023

👍

@anatawa12 anatawa12 deleted the feat-edit-antenna-from-column-menu branch July 5, 2023 04:33
anatawa12 added a commit to anatawa12/misskey that referenced this pull request Jul 13, 2023
* feat: add edit antenna button onto deck column

* feat: add edit list button onto deck column

* docs(changelog): add deck UIのカラムのメニューからアンテナとリストの編集画面を開けるようになりました

Cherry-picks: 1ab9f09
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* feat: add edit antenna button onto deck column

* feat: add edit list button onto deck column

* docs(changelog): add deck UIのカラムのメニューからアンテナとリストの編集画面を開けるようになりました
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
3 participants