feat(frontend): allow cropping images on drive #11092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #11092 +/- ##
===========================================
+ Coverage 77.37% 77.39% +0.02%
===========================================
Files 908 909 +1
Lines 91675 91793 +118
Branches 7550 7552 +2
===========================================
+ Hits 70937 71047 +110
- Misses 20738 20746 +8
|
|
ファイル名が継承された方が良さそう |
|
untitledになるのはMkCropperDialogの仕様なんだ… |
|
👍 |
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
* feat(frontend): allow cropping images on drive * nanka iroiro * folder --------- Co-authored-by: tamaina <[email protected]>
GrapeApple0
pushed a commit
to GrapeApple0/misskey
that referenced
this pull request
Jul 22, 2023
* feat(frontend): allow cropping images on drive * nanka iroiro * folder --------- Co-authored-by: tamaina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #11074
Why
OSでのクロップが不便な場合とかすでにアップロードされた映像をクロップしたい場合に使えるように
Additional info (optional)
テスト書きたかったですができませんでした😭
Cypressではなんとかできるかも？
Checklist