-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend): core/activitypub/models
#11067
refactor(backend): core/activitypub/models
#11067
Commits on Jul 2, 2023
-
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for d66322c - Browse repository at this point
Copy the full SHA d66322cView commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 1abb06d - Browse repository at this point
Copy the full SHA 1abb06dView commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 16ffe72 - Browse repository at this point
Copy the full SHA 16ffe72View commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for c9adcfa - Browse repository at this point
Copy the full SHA c9adcfaView commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 9889ad6 - Browse repository at this point
Copy the full SHA 9889ad6View commit details -
cleanup(
ApNoteService.ts
): unneededeslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for fb459de - Browse repository at this point
Copy the full SHA fb459deView commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 9dc2e98 - Browse repository at this point
Copy the full SHA 9dc2e98View commit details -
WIP(
ApImageService.ts
):image.url
をgetApHrefNullable()
に通すかどうか悩んでいるokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for aeefb84 - Browse repository at this point
Copy the full SHA aeefb84View commit details -
refactor(
ApNoteService.ts
): function return typeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 1246382 - Browse repository at this point
Copy the full SHA 1246382View commit details -
cleanup(
ApNoteService.ts
): deadcodeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for b203dab - Browse repository at this point
Copy the full SHA b203dabView commit details -
refactor(
ApNoteService.ts
):eslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for acce210 - Browse repository at this point
Copy the full SHA acce210View commit details -
refactor(
ApNoteService.ts
): non-null assertionこれまでは`getApId()`の方でエラーがスローされていた。
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 47a07d3 - Browse repository at this point
Copy the full SHA 47a07d3View commit details -
cleanup(
ApNoteService.ts
): unneeded awaitokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 370c1fb - Browse repository at this point
Copy the full SHA 370c1fbView commit details -
refactor(
ApNoteService.ts
): note.attachment- `toArray()`を使うように - よくわからない条件式を整理 - `as`をなくすために`promiseLimit()`でジェネリクスを使うように
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for dc291c5 - Browse repository at this point
Copy the full SHA dc291c5View commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 1af9392 - Browse repository at this point
Copy the full SHA 1af9392View commit details -
refactor(
ApNoteService.ts
): よりよい型定義`res`が`null`でないことは確認されているようだったので`null`とのunionはなくした
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for c234f3a - Browse repository at this point
Copy the full SHA c234f3aView commit details -
refactor(
ApNoteService.ts
): 不要な条件を削除okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for ad7b4e2 - Browse repository at this point
Copy the full SHA ad7b4e2View commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 688ad27 - Browse repository at this point
Copy the full SHA 688ad27View commit details -
cleanup(
ApNoteService.ts
): 重要でないas
を削除okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for c2b184b - Browse repository at this point
Copy the full SHA c2b184bView commit details -
refactor(
ApNoteService.ts
):eslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 394678e - Browse repository at this point
Copy the full SHA 394678eView commit details -
cleanup(
ApNoteService.ts
): deadcodeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for c788cbb - Browse repository at this point
Copy the full SHA c788cbbView commit details -
cleanup(
ApNoteService.ts
): unneeded non-null assertionokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for ad92cb6 - Browse repository at this point
Copy the full SHA ad92cb6View commit details -
refactor(
ApNoteService.ts
): 不要な条件を削除okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for a24e709 - Browse repository at this point
Copy the full SHA a24e709View commit details -
Configuration menu - View commit details
-
Copy full SHA for f688d7a - Browse repository at this point
Copy the full SHA f688d7aView commit details -
cleanup(
ApNoteService.ts
): 不要なas
を削除okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 8b3641e - Browse repository at this point
Copy the full SHA 8b3641eView commit details -
cleanup(
ApPersonService.ts
):no-unused-vars
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 3c17a9b - Browse repository at this point
Copy the full SHA 3c17a9bView commit details -
cleanup(
ApPersonService.ts
): deadcodeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 58abc86 - Browse repository at this point
Copy the full SHA 58abc86View commit details -
refactor(
ApPersonService.ts
): function return typeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for d3e23d9 - Browse repository at this point
Copy the full SHA d3e23d9View commit details -
cleanup(
ApPersonService.ts
): deadcodeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for c7fd197 - Browse repository at this point
Copy the full SHA c7fd197View commit details -
cleanup(
ApPersonService.ts
): deadcodeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 5095542 - Browse repository at this point
Copy the full SHA 5095542View commit details -
WIP(
ApPersonService.ts
):as
を調整`null`でないか確認する処理が続いていたので型アサーションは`null`とのunionにした。 より本質的な改善の余地があるように感じるのでひとまずWIPとしてコミット。
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 39ad3da - Browse repository at this point
Copy the full SHA 39ad3daView commit details -
refactor(
ApPersonService.ts
):eslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 44a1b6d - Browse repository at this point
Copy the full SHA 44a1b6dView commit details -
WIP(
ApPersonService.ts
):as any
をなくしたエラーをスローするようにせざるを得なかったのでエラーメッセージを考える必要がある。
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for b1ecaec - Browse repository at this point
Copy the full SHA b1ecaecView commit details -
WIP(
ApNoteService.ts
): non-null assertionnon-nullアサーションを減らすために事前に存在確認をするようにした。 エラーをスローするようにしたのでメッセージを考えなければならない。
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 71ca66e - Browse repository at this point
Copy the full SHA 71ca66eView commit details -
refactor(
ApNoteService.ts
): non-null assertion -> optional chainingokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 8ee31e8 - Browse repository at this point
Copy the full SHA 8ee31e8View commit details -
refactor(
ApPersonService.ts
):eslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for be415a9 - Browse repository at this point
Copy the full SHA be415a9View commit details -
refactor(
ApPersonService.ts
):eslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 4535728 - Browse repository at this point
Copy the full SHA 4535728View commit details -
refactor(
ApPersonService.ts
): function return typeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for a40ea81 - Browse repository at this point
Copy the full SHA a40ea81View commit details -
refactor(
ApPersonService.ts
): type guardによるnon-null assertionの削除okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for d276dab - Browse repository at this point
Copy the full SHA d276dabView commit details -
WIP(
ApPersonService.ts
):analyzeAttachments
- Field型を事前に定義しておくように - `attachments`が`IObject`だった場合、返り値が`{ fields: [] }`になるようだが構わないのか? - `toArray()`を通すべきでは?
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 785a5f6 - Browse repository at this point
Copy the full SHA 785a5f6View commit details -
Revert "WIP(
ApImageService.ts
):image.url
をgetApHrefNullable()
に通……すかどうか悩んでいる" This reverts commit aeefb84.
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 41fe1b6 - Browse repository at this point
Copy the full SHA 41fe1b6View commit details -
cleanup(
ApImageService.ts
):import
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 1454d04 - Browse repository at this point
Copy the full SHA 1454d04View commit details -
refactor(
ApImageService.ts
): 冗長だった部分を短くokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 67f9d9d - Browse repository at this point
Copy the full SHA 67f9d9dView commit details -
cleanup(
ApMentionService.ts
):import
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 244f672 - Browse repository at this point
Copy the full SHA 244f672View commit details -
refactor(
ApImageService.ts
):JSON.stringify()
でのindentationを追加okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for b651fb5 - Browse repository at this point
Copy the full SHA b651fb5View commit details -
cleanup(
ApNoteService.ts
):import
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for d8f0d76 - Browse repository at this point
Copy the full SHA d8f0d76View commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for bfc22e9 - Browse repository at this point
Copy the full SHA bfc22e9View commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 42b90cd - Browse repository at this point
Copy the full SHA 42b90cdView commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 7a82575 - Browse repository at this point
Copy the full SHA 7a82575View commit details -
cleanup(
ApNoteService.ts
):any
に対するnon-null assertionokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 3bd784e - Browse repository at this point
Copy the full SHA 3bd784eView commit details -
refactor(
ApNoteService.ts
): 添付ファイルokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 451a0e3 - Browse repository at this point
Copy the full SHA 451a0e3View commit details -
cleanup(
ApPersonService.ts
):import
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 5190ef9 - Browse repository at this point
Copy the full SHA 5190ef9View commit details -
refactor(
ApPersonService.ts
): より実情に即したas
にokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for f20381d - Browse repository at this point
Copy the full SHA f20381dView commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 541429f - Browse repository at this point
Copy the full SHA 541429fView commit details -
refactor(
ApPersonService.ts
): 冗長だった部分を修正okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for a003fb2 - Browse repository at this point
Copy the full SHA a003fb2View commit details -
cleanup(
ApPersonService.ts
): deadcodeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 8cd1152 - Browse repository at this point
Copy the full SHA 8cd1152View commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for f4a8e74 - Browse repository at this point
Copy the full SHA f4a8e74View commit details -
cleanup(
ApQuestionService.ts
):import
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 778585e - Browse repository at this point
Copy the full SHA 778585eView commit details -
refactor(
ApQuestionService.ts
):eslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for fcc6042 - Browse repository at this point
Copy the full SHA fcc6042View commit details -
refactor(
ApQuestionService.ts
):eslint-disable-next-line
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for f70fd08 - Browse repository at this point
Copy the full SHA f70fd08View commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 279321e - Browse repository at this point
Copy the full SHA 279321eView commit details -
refactor(
ApQuestionService.ts
): non-null assertionを消したokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 0f8686d - Browse repository at this point
Copy the full SHA 0f8686dView commit details -
okayurisotto committed
Jul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 5e715b2 - Browse repository at this point
Copy the full SHA 5e715b2View commit details -
WIP(
ApQuestionService.ts
): non-null assertionを消すエラーメッセージを考える必要がある。
okayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for d0e00c8 - Browse repository at this point
Copy the full SHA d0e00c8View commit details -
refactor(
ApQuestionService.ts
):any
を消すokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 630078f - Browse repository at this point
Copy the full SHA 630078fView commit details -
refactor(
ApQuestionService.ts
): function return typeokayurisotto committedJul 2, 2023 Configuration menu - View commit details
-
Copy full SHA for afe16d7 - Browse repository at this point
Copy the full SHA afe16d7View commit details
Commits on Jul 3, 2023
-
WIP(
ApPersonService.ts
): 可読性の低い三項演算子を削除しつつnon-null assertionを回避エラーメッセージを考える必要がある。
okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 09f6720 - Browse repository at this point
Copy the full SHA 09f6720View commit details -
cleanup(
ApPersonService.ts
): 不必要な三項演算子を削除okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for eb0607e - Browse repository at this point
Copy the full SHA eb0607eView commit details -
cleanup(
ApPersonService.ts
): 不要なas
okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 9801b20 - Browse repository at this point
Copy the full SHA 9801b20View commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 8e46204 - Browse repository at this point
Copy the full SHA 8e46204View commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 56a6608 - Browse repository at this point
Copy the full SHA 56a6608View commit details -
refactor(
ApPersonService.ts
): 可読性の低い三項演算子を削除元の実装が悪いと判断し`null`かどうかの確認をより厳密に行うようにした。
okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 37d5c2c - Browse repository at this point
Copy the full SHA 37d5c2cView commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for a234675 - Browse repository at this point
Copy the full SHA a234675View commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for c2c2efb - Browse repository at this point
Copy the full SHA c2c2efbView commit details -
refactor(
ApPersonService.ts
): 返り値をvoid
に統一この返り値を参照しているコードは見当たらなかった。 また、普通に意味がない値であるように見受けられた。
okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for bfa0fcd - Browse repository at this point
Copy the full SHA bfa0fcdView commit details -
fixup! refactor(
ApPersonService.ts
): 返り値をvoid
に統一okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 083cd67 - Browse repository at this point
Copy the full SHA 083cd67View commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for d4ffb25 - Browse repository at this point
Copy the full SHA d4ffb25View commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 12516b9 - Browse repository at this point
Copy the full SHA 12516b9View commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 5bf82ff - Browse repository at this point
Copy the full SHA 5bf82ffView commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for ff57dc0 - Browse repository at this point
Copy the full SHA ff57dc0View commit details -
refactor(
ApPersonService.ts
): 返り値のvoid
統一と条件式の調整この返り値を参照しているコードは見当たらなかった。 また、普通に意味がない値であるように見受けられた。
okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 662d2b1 - Browse repository at this point
Copy the full SHA 662d2b1View commit details -
okayurisotto committed
Jul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 264ae11 - Browse repository at this point
Copy the full SHA 264ae11View commit details -
refactor(
ApQuestionService.ts
)okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 42fed0c - Browse repository at this point
Copy the full SHA 42fed0cView commit details -
refactor(
ApQuestionService.ts
)okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 58dbf61 - Browse repository at this point
Copy the full SHA 58dbf61View commit details -
refactor(
tag.ts
): function return typeokayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for c6897ea - Browse repository at this point
Copy the full SHA c6897eaView commit details -
fixup! enhance: account migration (#10592)
okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 6dfbf60 - Browse repository at this point
Copy the full SHA 6dfbf60View commit details -
fixup! WIP(
ApPersonService.ts
): 可読性の低い三項演算子を削除しつつnon-null assertionを回避okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for f2bc374 - Browse repository at this point
Copy the full SHA f2bc374View commit details -
fixup! cleanup(
ApPersonService.ts
): 不要なas
okayurisotto committedJul 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 6f61e66 - Browse repository at this point
Copy the full SHA 6f61e66View commit details
Commits on Jul 4, 2023
-
okayurisotto committed
Jul 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 01e6dfb - Browse repository at this point
Copy the full SHA 01e6dfbView commit details -
Merge branch 'develop' into refactor-backend-core-activitypub
okayurisotto authoredJul 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 890faa8 - Browse repository at this point
Copy the full SHA 890faa8View commit details -
Revert "cleanup(
ApImageService.ts
):import
"This reverts commit 1454d04.
okayurisotto committedJul 4, 2023 Configuration menu - View commit details
-
Copy full SHA for f11c601 - Browse repository at this point
Copy the full SHA f11c601View commit details -
Revert "cleanup(
ApMentionService.ts
):import
"This reverts commit 244f672.
okayurisotto committedJul 4, 2023 Configuration menu - View commit details
-
Copy full SHA for abecfc4 - Browse repository at this point
Copy the full SHA abecfc4View commit details -
Revert "cleanup(
ApNoteService.ts
):import
"This reverts commit d8f0d76.
okayurisotto committedJul 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 4522ad1 - Browse repository at this point
Copy the full SHA 4522ad1View commit details -
Revert "cleanup(
ApPersonService.ts
):import
"This reverts commit 5190ef9. # Conflicts: # packages/backend/src/core/activitypub/models/ApPersonService.ts
okayurisotto committedJul 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 0988437 - Browse repository at this point
Copy the full SHA 0988437View commit details -
Revert "cleanup(
ApQuestionService.ts
):import
"This reverts commit 778585e.
okayurisotto committedJul 4, 2023 Configuration menu - View commit details
-
Copy full SHA for bd2bc1c - Browse repository at this point
Copy the full SHA bd2bc1cView commit details
Commits on Jul 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ac8f9fa - Browse repository at this point
Copy the full SHA ac8f9faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99c8f7c - Browse repository at this point
Copy the full SHA 99c8f7cView commit details -
Revert "fixup! refactor(
ApPersonService.ts
): 返り値をvoid
に統一"This reverts commit 083cd67.
okayurisotto committedJul 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 081df38 - Browse repository at this point
Copy the full SHA 081df38View commit details -
Revert "refactor(
ApPersonService.ts
): 返り値をvoid
に統一"This reverts commit bfa0fcd.
okayurisotto committedJul 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 61ba747 - Browse repository at this point
Copy the full SHA 61ba747View commit details -
Merge branch 'develop' into refactor-backend-core-activitypub
okayurisotto authoredJul 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 86c0dc0 - Browse repository at this point
Copy the full SHA 86c0dc0View commit details