Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(backend): core/activitypub/models #11067

Merged
merged 100 commits into from
Jul 7, 2023
Merged

refactor(backend): core/activitypub/models #11067

merged 100 commits into from
Jul 7, 2023

Commits on Jul 2, 2023

  1. cleanup(ApImageService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d66322c View commit details
    Browse the repository at this point in the history

  2. refactor(ApImageService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    1abb06d View commit details
    Browse the repository at this point in the history

  3. cleanup(check-https.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    16ffe72 View commit details
    Browse the repository at this point in the history

  4. cleanup(ApMentionService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c9adcfa View commit details
    Browse the repository at this point in the history

  5. refactor(ApMentionService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    9889ad6 View commit details
    Browse the repository at this point in the history

  6. cleanup(ApNoteService.ts): unneeded eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    fb459de View commit details
    Browse the repository at this point in the history

  7. cleanup(ApNoteService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    9dc2e98 View commit details
    Browse the repository at this point in the history

  8. WIP(ApImageService.ts): image.urlをgetApHrefNullable()に通すかどうか悩んでいる

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    aeefb84 View commit details
    Browse the repository at this point in the history

  9. refactor(ApNoteService.ts): function return type

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    1246382 View commit details
    Browse the repository at this point in the history

  10. cleanup(ApNoteService.ts): deadcode

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    b203dab View commit details
    Browse the repository at this point in the history

  11. refactor(ApNoteService.ts): eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    acce210 View commit details
    Browse the repository at this point in the history

  12. refactor(ApNoteService.ts): non-null assertion 

    これまでは`getApId()`の方でエラーがスローされていた。
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    47a07d3 View commit details
    Browse the repository at this point in the history

  13. cleanup(ApNoteService.ts): unneeded await

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    370c1fb View commit details
    Browse the repository at this point in the history

  14. refactor(ApNoteService.ts): note.attachment 

    - `toArray()`を使うように
- よくわからない条件式を整理
- `as`をなくすために`promiseLimit()`でジェネリクスを使うように
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    dc291c5 View commit details
    Browse the repository at this point in the history

  15. cleanup(ApNoteService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    1af9392 View commit details
    Browse the repository at this point in the history

  16. refactor(ApNoteService.ts): よりよい型定義 

    `res`が`null`でないことは確認されているようだったので`null`とのunionはなくした
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c234f3a View commit details
    Browse the repository at this point in the history

  17. refactor(ApNoteService.ts): 不要な条件を削除

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    ad7b4e2 View commit details
    Browse the repository at this point in the history

  18. cleanup(ApNoteService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    688ad27 View commit details
    Browse the repository at this point in the history

  19. cleanup(ApNoteService.ts): 重要でないasを削除

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c2b184b View commit details
    Browse the repository at this point in the history

  20. refactor(ApNoteService.ts): eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    394678e View commit details
    Browse the repository at this point in the history

  21. cleanup(ApNoteService.ts): deadcode

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c788cbb View commit details
    Browse the repository at this point in the history

  22. cleanup(ApNoteService.ts): unneeded non-null assertion

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    ad92cb6 View commit details
    Browse the repository at this point in the history

  23. refactor(ApNoteService.ts): 不要な条件を削除

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    a24e709 View commit details
    Browse the repository at this point in the history

  24. WIP(ApNoteService.ts): asをなくす 

    エラーメッセージを考える
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    f688d7a View commit details
    Browse the repository at this point in the history

  25. cleanup(ApNoteService.ts): 不要なasを削除

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    8b3641e View commit details
    Browse the repository at this point in the history

  26. cleanup(ApPersonService.ts): no-unused-vars

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    3c17a9b View commit details
    Browse the repository at this point in the history

  27. cleanup(ApPersonService.ts): deadcode

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    58abc86 View commit details
    Browse the repository at this point in the history

  28. refactor(ApPersonService.ts): function return type

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d3e23d9 View commit details
    Browse the repository at this point in the history

  29. cleanup(ApPersonService.ts): deadcode

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c7fd197 View commit details
    Browse the repository at this point in the history

  30. cleanup(ApPersonService.ts): deadcode

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    5095542 View commit details
    Browse the repository at this point in the history

  31. WIP(ApPersonService.ts): asを調整 

    `null`でないか確認する処理が続いていたので型アサーションは`null`とのunionにした。
より本質的な改善の余地があるように感じるのでひとまずWIPとしてコミット。
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    39ad3da View commit details
    Browse the repository at this point in the history

  32. refactor(ApPersonService.ts): eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    44a1b6d View commit details
    Browse the repository at this point in the history

  33. WIP(ApPersonService.ts): as anyをなくした 

    エラーをスローするようにせざるを得なかったのでエラーメッセージを考える必要がある。
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    b1ecaec View commit details
    Browse the repository at this point in the history

  34. WIP(ApNoteService.ts): non-null assertion 

    non-nullアサーションを減らすために事前に存在確認をするようにした。
エラーをスローするようにしたのでメッセージを考えなければならない。
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    71ca66e View commit details
    Browse the repository at this point in the history

  35. refactor(ApNoteService.ts): non-null assertion -> optional chaining

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    8ee31e8 View commit details
    Browse the repository at this point in the history

  36. refactor(ApPersonService.ts): eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    be415a9 View commit details
    Browse the repository at this point in the history

  37. refactor(ApPersonService.ts): eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    4535728 View commit details
    Browse the repository at this point in the history

  38. refactor(ApPersonService.ts): function return type

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    a40ea81 View commit details
    Browse the repository at this point in the history

  39. refactor(ApPersonService.ts): type guardによるnon-null assertionの削除

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d276dab View commit details
    Browse the repository at this point in the history

  40. WIP(ApPersonService.ts): analyzeAttachments 

    - Field型を事前に定義しておくように

- `attachments`が`IObject`だった場合、返り値が`{ fields: [] }`になるようだが構わないのか？
- `toArray()`を通すべきでは？
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    785a5f6 View commit details
    Browse the repository at this point in the history

  41. Revert "WIP(ApImageService.ts): image.urlをgetApHrefNullable()に通… 

    …すかどうか悩んでいる"

This reverts commit aeefb84.
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    41fe1b6 View commit details
    Browse the repository at this point in the history

  42. cleanup(ApImageService.ts): import

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    1454d04 View commit details
    Browse the repository at this point in the history

  43. refactor(ApImageService.ts): 冗長だった部分を短く

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    67f9d9d View commit details
    Browse the repository at this point in the history

  44. cleanup(ApMentionService.ts): import

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    244f672 View commit details
    Browse the repository at this point in the history

  45. refactor(ApImageService.ts): JSON.stringify()でのindentationを追加

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    b651fb5 View commit details
    Browse the repository at this point in the history

  46. cleanup(ApNoteService.ts): import

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d8f0d76 View commit details
    Browse the repository at this point in the history

  47. cleanup(ApNoteService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    bfc22e9 View commit details
    Browse the repository at this point in the history

  48. cleanup(ApNoteService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    42b90cd View commit details
    Browse the repository at this point in the history

  49. cleanup(ApNoteService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    7a82575 View commit details
    Browse the repository at this point in the history

  50. cleanup(ApNoteService.ts): anyに対するnon-null assertion

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    3bd784e View commit details
    Browse the repository at this point in the history

  51. refactor(ApNoteService.ts): 添付ファイル

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    451a0e3 View commit details
    Browse the repository at this point in the history

  52. cleanup(ApPersonService.ts): import

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    5190ef9 View commit details
    Browse the repository at this point in the history

  53. refactor(ApPersonService.ts): より実情に即したasに

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    f20381d View commit details
    Browse the repository at this point in the history

  54. cleanup(ApPersonService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    541429f View commit details
    Browse the repository at this point in the history

  55. refactor(ApPersonService.ts): 冗長だった部分を修正

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    a003fb2 View commit details
    Browse the repository at this point in the history

  56. cleanup(ApPersonService.ts): deadcode

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    8cd1152 View commit details
    Browse the repository at this point in the history

  57. cleanup(ApPersonService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    f4a8e74 View commit details
    Browse the repository at this point in the history

  58. cleanup(ApQuestionService.ts): import

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    778585e View commit details
    Browse the repository at this point in the history

  59. refactor(ApQuestionService.ts): eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    fcc6042 View commit details
    Browse the repository at this point in the history

  60. refactor(ApQuestionService.ts): eslint-disable-next-line

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    f70fd08 View commit details
    Browse the repository at this point in the history

  61. cleanup(ApQuestionService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    279321e View commit details
    Browse the repository at this point in the history

  62. refactor(ApQuestionService.ts): non-null assertionを消した

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    0f8686d View commit details
    Browse the repository at this point in the history

  63. cleanup(ApQuestionService.ts)

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    5e715b2 View commit details
    Browse the repository at this point in the history

  64. WIP(ApQuestionService.ts): non-null assertionを消す 

    エラーメッセージを考える必要がある。
    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d0e00c8 View commit details
    Browse the repository at this point in the history

  65. refactor(ApQuestionService.ts): anyを消す

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    630078f View commit details
    Browse the repository at this point in the history

  66. refactor(ApQuestionService.ts): function return type

    okayurisotto committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    afe16d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. WIP(ApPersonService.ts): 可読性の低い三項演算子を削除しつつnon-null assertionを回避 

    エラーメッセージを考える必要がある。
    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    09f6720 View commit details
    Browse the repository at this point in the history

  2. cleanup(ApPersonService.ts): 不必要な三項演算子を削除

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    eb0607e View commit details
    Browse the repository at this point in the history

  3. cleanup(ApPersonService.ts): 不要なas

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    9801b20 View commit details
    Browse the repository at this point in the history

  4. cleanup(ApPersonService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    8e46204 View commit details
    Browse the repository at this point in the history

  5. refactor(ApPersonService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    56a6608 View commit details
    Browse the repository at this point in the history

  6. refactor(ApPersonService.ts): 可読性の低い三項演算子を削除 

    元の実装が悪いと判断し`null`かどうかの確認をより厳密に行うようにした。
    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    37d5c2c View commit details
    Browse the repository at this point in the history

  7. cleanup(ApPersonService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    a234675 View commit details
    Browse the repository at this point in the history

  8. cleanup(ApPersonService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    c2c2efb View commit details
    Browse the repository at this point in the history

  9. refactor(ApPersonService.ts): 返り値をvoidに統一 

    この返り値を参照しているコードは見当たらなかった。
また、普通に意味がない値であるように見受けられた。
    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    bfa0fcd View commit details
    Browse the repository at this point in the history

  10. fixup! refactor(ApPersonService.ts): 返り値をvoidに統一

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    083cd67 View commit details
    Browse the repository at this point in the history

  11. refactor(ApNoteService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    d4ffb25 View commit details
    Browse the repository at this point in the history

  12. refactor(ApPersonService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    12516b9 View commit details
    Browse the repository at this point in the history

  13. cleanup(ApPersonService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    5bf82ff View commit details
    Browse the repository at this point in the history

  14. cleanup(ApPersonService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ff57dc0 View commit details
    Browse the repository at this point in the history

  15. refactor(ApPersonService.ts): 返り値のvoid統一と条件式の調整 

    この返り値を参照しているコードは見当たらなかった。
また、普通に意味がない値であるように見受けられた。
    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    662d2b1 View commit details
    Browse the repository at this point in the history

  16. cleanup(ApQuestionService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    264ae11 View commit details
    Browse the repository at this point in the history

  17. refactor(ApQuestionService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    42fed0c View commit details
    Browse the repository at this point in the history

  18. refactor(ApQuestionService.ts)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    58dbf61 View commit details
    Browse the repository at this point in the history

  19. refactor(tag.ts): function return type

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    c6897ea View commit details
    Browse the repository at this point in the history

  20. fixup! enhance: account migration (#10592)

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6dfbf60 View commit details
    Browse the repository at this point in the history

  21. fixup! WIP(ApPersonService.ts): 可読性の低い三項演算子を削除しつつnon-null assertionを回避

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f2bc374 View commit details
    Browse the repository at this point in the history

  22. fixup! cleanup(ApPersonService.ts): 不要なas

    okayurisotto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6f61e66 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. refactor: エラーメッセージを見繕った

    okayurisotto committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    01e6dfb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into refactor-backend-core-activitypub

    okayurisotto authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    890faa8 View commit details
    Browse the repository at this point in the history

  3. Revert "cleanup(ApImageService.ts): import" 

    This reverts commit 1454d04.
    okayurisotto committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f11c601 View commit details
    Browse the repository at this point in the history

  4. Revert "cleanup(ApMentionService.ts): import" 

    This reverts commit 244f672.
    okayurisotto committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    abecfc4 View commit details
    Browse the repository at this point in the history

  5. Revert "cleanup(ApNoteService.ts): import" 

    This reverts commit d8f0d76.
    okayurisotto committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4522ad1 View commit details
    Browse the repository at this point in the history

  6. Revert "cleanup(ApPersonService.ts): import" 

    This reverts commit 5190ef9.

# Conflicts:
#	packages/backend/src/core/activitypub/models/ApPersonService.ts
    okayurisotto committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0988437 View commit details
    Browse the repository at this point in the history

  7. Revert "cleanup(ApQuestionService.ts): import" 

    This reverts commit 778585e.
    okayurisotto committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    bd2bc1c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Merge branch 'develop' into pr/okayurisotto/11067

    @tamaina
    tamaina committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ac8f9fa View commit details
    Browse the repository at this point in the history

  2. processRemoteMoveはそのままにしてほしい

    @tamaina
    tamaina committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    99c8f7c View commit details
    Browse the repository at this point in the history

  3. Revert "fixup! refactor(ApPersonService.ts): 返り値をvoidに統一" 

    This reverts commit 083cd67.
    okayurisotto committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    081df38 View commit details
    Browse the repository at this point in the history

  4. Revert "refactor(ApPersonService.ts): 返り値をvoidに統一" 

    This reverts commit bfa0fcd.
    okayurisotto committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    61ba747 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into refactor-backend-core-activitypub

    okayurisotto authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    86c0dc0 View commit details
    Browse the repository at this point in the history