Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/roles/usersにてuserIdで指定できるように #11059

Closed
wants to merge 1 commit into from

Conversation

nenohi
Copy link
Contributor

@nenohi nenohi commented Jun 29, 2023

What

タイトル通り

Why

ロールの期限にてuserIdでのフィルターができないため

Additional info (optional)

ローカル環境にてテスト済み

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #11059 (77b19fd) into develop (1b1f82a) will increase coverage by 0.17%.
The diff coverage is 16.66%.

@@             Coverage Diff             @@
##           develop   #11059      +/-   ##
===========================================
+ Coverage    77.34%   77.52%   +0.17%     
===========================================
  Files          739      909     +170     
  Lines        70532    91562   +21030     
  Branches      7103     7569     +466     
===========================================
+ Hits         54550    70979   +16429     
- Misses       15982    20583    +4601     
Impacted Files Coverage Δ
...kend/src/server/api/endpoints/admin/roles/users.ts 62.65% <16.66%> (-2.74%) ⬇️

... and 186 files with indirect coverage changes

@syuilo
Copy link
Member

syuilo commented Jul 1, 2023

ロールの期限にてuserIdでのフィルターができない

がよくわからなかった👀

@nenohi
Copy link
Contributor Author

nenohi commented Jul 2, 2023

ロールの期限を取得するのにユーザーIDを指定して期限を見たい場合に現状では難しいのでは?
といった感じ

@syuilo
Copy link
Member

syuilo commented Jul 8, 2023

「あるユーザーにあるロールが期限付きでアサインされている場合、その期限情報を見たい」ってことであってる?

@syuilo
Copy link
Member

syuilo commented Jul 8, 2023

だとすると admin/roles/users に userId を指定できるようにする以外の解決策を考えた方がよさそう(ユーザー一覧を取得するAPIにユーザーID指定パラメータがあるのは不自然)

@nenohi
Copy link
Contributor Author

nenohi commented Jul 8, 2023

admin/show-userで期限まで取ってこようと思ったけど期限だけが別プロパティになってしまいうーーんとなってるところ

@syuilo syuilo closed this in 871027f Jul 20, 2023
@syuilo
Copy link
Member

syuilo commented Jul 20, 2023

やった

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants