Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend/test): add interface UserToken #11050

Merged
merged 1 commit into from
Jun 26, 2023
Merged

refactor(backend/test): add interface UserToken #11050

merged 1 commit into from
Jun 26, 2023

Conversation

saschanaz
Copy link
Member

What

タイトル通り

Why

anyの数をもっと減らすため(me.tokenだけ使うし、一部テストで偽tokenを送ったりするのでMeSignupは使いませんでした)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #11050 (db1f560) into develop (58a898d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11050      +/-   ##
===========================================
- Coverage    77.38%   77.34%   -0.05%     
===========================================
  Files          905      907       +2     
  Lines        90903    91365     +462     
  Branches      7491     7522      +31     
===========================================
+ Hits         70344    70662     +318     
- Misses       20559    20703     +144     

see 17 files with indirect coverage changes

@syuilo syuilo merged commit d48172e into develop Jun 26, 2023
@syuilo syuilo deleted the usertoken branch June 26, 2023 23:07
@syuilo
Copy link
Member

syuilo commented Jun 26, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants