Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: 自動でたたまれる機能が返信先や引用RNにも適用されるように #10989

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

kabo2468
Copy link
Contributor

@kabo2468 kabo2468 commented Jun 10, 2023

What

Resolve #7478, Resolve #10031
自動でたたまれる対象にpositionを外した

Why

#10165 (comment)
#10165 (comment)

Additional info (optional)

返信先や引用RNだと開いたものを再度閉じることができないので、邪魔になる可能性がある
これで直った ac6d6fd

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 10, 2023
@github-actions github-actions bot requested review from syuilo and tamaina June 10, 2023 14:29
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #10989 (0dfff13) into develop (b3358f0) will decrease coverage by 0.03%.
The diff coverage is 39.13%.

❗ Current head 0dfff13 differs from pull request most recent head 4170b9e. Consider uploading reports for the commit 4170b9e to get more accurate results

@@             Coverage Diff             @@
##           develop   #10989      +/-   ##
===========================================
- Coverage    77.72%   77.69%   -0.03%     
===========================================
  Files          919      173     -746     
  Lines        92728    21600   -71128     
  Branches      7748      498    -7250     
===========================================
- Hits         72071    16782   -55289     
+ Misses       20657     4818   -15839     
Impacted Files Coverage Δ
packages/frontend/src/scripts/collapsed.ts 26.31% <26.31%> (ø)
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)
...kages/frontend/src/components/MkSubNoteContent.vue 100.00% <100.00%> (ø)

... and 747 files with indirect coverage changes

@acid-chicken acid-chicken merged commit a8cd8ed into misskey-dev:develop Jul 21, 2023
10 checks passed
@kabo2468 kabo2468 deleted the mfm-reply-renote branch July 21, 2023 10:11
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* 返信、引用RNでMFMがあったら自動で隠すように

* Update CHANGELOG.md

* Update MkSubNoteContent.vue

* refactor: avoid `Boolean`

* docs: update CHANGELOG.md

---------

Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
2 participants