fix(backend): Remove Meilisearch index when notes are deleted #10988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #10988 +/- ##
===========================================
+ Coverage 77.34% 77.38% +0.04%
===========================================
Files 908 910 +2
Lines 91675 91857 +182
Branches 7546 7555 +9
===========================================
+ Hits 70904 71085 +181
- Misses 20771 20772 +1
|
caipira113
changed the title
saschanaz
reviewed
Jun 26, 2023
`cascadingNotesFilter` -> `federatedLocalCascadingNotes`
syuilo
reviewed
Jul 8, 2023
| @@ -114,6 +117,11 @@ export class NoteDeleteService { | |||
| } | |||
| } | |||
|
|
|||
| for (const cascadingNote of cascadingNotes) { | |||
| await this.searchService.unindexNote(cascadingNote); | |||
There was a problem hiding this comment.
awaitする必要はないかも？
Suggested change
| await this.searchService.unindexNote(cascadingNote); | |
| this.searchService.unindexNote(cascadingNote); |
|
👍 |
|
Can this be tested? 🤔 |
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
…y-dev#10988) * fix(backend): Include feature to delete Meilisearch index notes * Update variable name `cascadingNotesFilter` -> `federatedLocalCascadingNotes` * tweak --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve #11193
Added functionality to delete Meilisearch indexed notes when deleting a note.
Why
When using Meilisearch on the server, indexed notes were not being removed even when the notes were deleted. This was not ideal for both privacy and server management.
Additional info (optional)
At least in my local testing, it has been confirmed that the feature works on both local and remote.
Checklist