Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(frontend): use setInterval instead of setTimeout chain in MkTime #10981

Merged
merged 11 commits into from
Jul 4, 2023
Merged

perf(frontend): use setInterval instead of setTimeout chain in MkTime #10981

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2f5efdd
perf(frontend): use setInterval instead of setTimeout chain in MkTime
tamaina Jun 9, 2023
a20f8f2
fix
tamaina Jun 9, 2023
16ebe56
props.origin
tamaina Jun 9, 2023
c464e7d
props.origin 2
tamaina Jun 9, 2023
28b181e
fix
tamaina Jun 9, 2023
0dbb9cf
add comment
tamaina Jun 10, 2023
c8f14d2
setIntervalを再設定する
tamaina Jun 10, 2023
5e6f4e5
Merge branch 'develop' into use-interval
tamaina Jun 10, 2023
f0406a3
Merge branch 'develop' into use-interval
tamaina Jul 2, 2023
edb06d3
refactor
tamaina Jul 4, 2023
a417fc5
Merge branch 'develop' into use-interval
tamaina Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions packages/frontend/src/components/global/MkTime.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<script lang="ts" setup>
import isChromatic from 'chromatic/isChromatic';
import { onUnmounted } from 'vue';
import { onMounted, onUnmounted } from 'vue';
import { i18n } from '@/i18n';
import { dateTimeFormat } from '@/scripts/intl-const';

Expand Down Expand Up @@ -49,17 +49,21 @@ const relative = $computed<string>(() => {
let tickId: number;

function tick() {
now = props.origin ?? (new Date()).getTime();
tamaina marked this conversation as resolved.
Show resolved Hide resolved
const ago = (now - _time) / 1000/*ms*/;
const _now = (new Date()).getTime();
const ago = (_now - _time) / 1000/*ms*/;
const next = ago < 60 ? 10000 : ago < 3600 ? 60000 : 180000;

tickId = window.setTimeout(tick, next);
if (_now - now > next) {
now = _now;
}
tamaina marked this conversation as resolved.
Show resolved Hide resolved
}

if (props.mode === 'relative' || props.mode === 'detail') {
tick();
if (!invalid && (props.mode === 'relative' || props.mode === 'detail' || props.origin === null)) {
onMounted(() => {
tickId = window.setInterval(tick, 10000);
});
onUnmounted(() => {
window.clearTimeout(tickId);
if (tickId) window.clearInterval(tickId);
});
}
</script>