Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #10955 TypeError: JSON5.parse is not a function #10956

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

CaffeeLake
Copy link
Contributor

What

Fix: #10955 TypeError: JSON5.parse is not a function

Why

v13.13.0にアップデート後、ページが表示されない問題がある。
サーバー側のログでは、TypeError: JSON5.parse is not a function と出ているので、怪しい部分を修正。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #10956 (d3a9d8e) into develop (259be25) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #10956      +/-   ##
===========================================
- Coverage    77.43%   77.39%   -0.04%     
===========================================
  Files          910      908       -2     
  Lines        91576    91417     -159     
  Branches      6880     6880              
===========================================
- Hits         70915    70756     -159     
  Misses       20661    20661              
Impacted Files Coverage Δ
packages/backend/src/server/api/endpoints/meta.ts 75.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@CaffeeLake CaffeeLake changed the title Fix: #10955 Fix: #10955 TypeError: JSON5.parse is not a function Jun 5, 2023
@tamaina tamaina merged commit 8263cc0 into misskey-dev:develop Jun 5, 2023
@tamaina
Copy link
Contributor

tamaina commented Jun 5, 2023

🙏 🙏🙏🙏

@CaffeeLake CaffeeLake deleted the fix-json5 branch June 5, 2023 12:45
nafu-at pushed a commit to TeamNijimiss/nijimiss_legacy that referenced this pull request Jun 5, 2023
…key-dev#10956)

* Fix: JSON5.parse is not a function

* update changelog

* update chglog

---------

Co-authored-by: tamaina <[email protected]>
hideki0403 pushed a commit to hideki0403/kakurega.app that referenced this pull request Jun 5, 2023
…key-dev#10956)

* Fix: JSON5.parse is not a function

* update changelog

* update chglog

---------

Co-authored-by: tamaina <[email protected]>
EbiseLutica pushed a commit to shrimpia/misskey that referenced this pull request Jun 5, 2023
…key-dev#10956)

* Fix: JSON5.parse is not a function

* update changelog

* update chglog

---------

Co-authored-by: tamaina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: JSON5.parse is not a function
2 participants