Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: プレイにAPI Tokenを要求できる関数を追加 #10949

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

chocolate-pie
Copy link
Contributor

@chocolate-pie chocolate-pie commented Jun 4, 2023

What

プレイにAPIトークンを要求できる関数を追加しました

video.mp4

Why

プレイからAPI Tokenを要求できる関数があった方が便利なため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js labels Jun 4, 2023
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #10949 (e4e8e70) into develop (7097d55) will increase coverage by 0.08%.
The diff coverage is 80.00%.

❗ Current head e4e8e70 differs from pull request most recent head e987077. Consider uploading reports for the commit e987077 to get more accurate results

@@             Coverage Diff             @@
##           develop   #10949      +/-   ##
===========================================
+ Coverage    77.68%   77.77%   +0.08%     
===========================================
  Files          919      911       -8     
  Lines        92635    91912     -723     
  Branches      7749     7757       +8     
===========================================
- Hits         71967    71488     -479     
+ Misses       20668    20424     -244     
Impacted Files Coverage Δ
packages/backend/src/misc/flash-token.ts 0.00% <0.00%> (ø)
...kages/backend/src/server/api/endpoints/app/show.ts 76.27% <50.00%> (ø)
packages/backend/src/server/api/ApiCallService.ts 74.44% <68.75%> (-0.62%) ⬇️
...ages/backend/src/server/api/AuthenticateService.ts 76.92% <75.00%> (+0.39%) ⬆️
...ackend/src/server/api/endpoints/flash/gen-token.ts 83.92% <83.92%> (ø)
packages/backend/src/core/CacheService.ts 100.00% <100.00%> (+4.10%) ⬆️
packages/backend/src/server/api/EndpointsModule.ts 100.00% <100.00%> (ø)
packages/backend/src/server/api/endpoint-base.ts 94.28% <100.00%> (+0.08%) ⬆️
packages/backend/src/server/api/endpoints.ts 100.00% <100.00%> (ø)
...end/src/server/api/endpoints/drive/files/create.ts 91.20% <100.00%> (ø)
... and 5 more

... and 103 files with indirect coverage changes

@chocolate-pie chocolate-pie marked this pull request as ready for review June 5, 2023 02:17
@chocolate-pie chocolate-pie reopened this Jun 5, 2023
@github-actions github-actions bot requested a review from tamaina June 5, 2023 10:02
@kakkokari-gtyih
Copy link
Contributor

Playの翻訳は「プレイ」ではなく「Play」のままでいいはず

image

@chocolate-pie
Copy link
Contributor Author

@kakkokari-gtyih 直しました。

@chocolate-pie chocolate-pie marked this pull request as draft June 6, 2023 11:34
@chocolate-pie chocolate-pie marked this pull request as ready for review June 7, 2023 02:01
@github-actions github-actions bot requested a review from syuilo June 7, 2023 02:02
@chocolate-pie
Copy link
Contributor Author

@syuilo 失礼ですが、このプルリクエストをマージする予定はありますか?無ければ閉じますけど

@tamaina
Copy link
Contributor

tamaina commented Jul 10, 2023

ないんじゃない

@tamaina tamaina closed this Jul 10, 2023
@syuilo
Copy link
Member

syuilo commented Jul 10, 2023

@syuilo 失礼ですが、このプルリクエストをマージする予定はありますか?無ければ閉じますけど

まだ見れてないのでなんとも言えません🙏

@tamaina tamaina reopened this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Development

Successfully merging this pull request may close these issues.

4 participants