fix(backend): Use SSL option for Meilisearch #10772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #10772 +/- ##
===========================================
+ Coverage 77.35% 78.35% +1.00%
===========================================
Files 901 167 -734
Lines 89690 20741 -68949
Branches 6573 374 -6199
===========================================
- Hits 69377 16252 -53125
+ Misses 20313 4489 -15824 |
|
👍 |
sasagar
pushed a commit
to sasagar/misskey
that referenced
this pull request
May 9, 2023
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve #10767
Added SSL option to Meilisearch configuration.
Why
The current code uses an HTTP connection to communicate with the Meilisearch server. However, when the server has SSL configured, this results in connection failures. To solve this problem, the SSL option has been added to the configuration.
Additional info (optional)
Configuring SSL in Meilisearch itself with
MEILI_SSL_CERT_PATH(--ssl-cert-path) andMEILI_SSL_KEY_PATH(--ssl-key-path) still doesn't seem to work. Therefore, it appears that using a separate reverse proxy is necessary to enable SSL.Checklist