perf: use slacc on check-word-mute #10721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
Codecov Report
@@ Coverage Diff @@
## develop #10721 +/- ##
===========================================
+ Coverage 77.32% 77.36% +0.04%
===========================================
Files 901 901
Lines 89672 89690 +18
Branches 6558 6583 +25
===========================================
+ Hits 69339 69391 +52
+ Misses 20333 20299 -34
|
This comment was marked as resolved.
This comment was marked as resolved.
acid-chicken
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
acid-chicken
commented
Apr 27, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
|
slaccはモジュールごとにnpmからインストールするようにするのがいいかも |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
|
RustっぽいけどJSから呼び出す際のオーバーヘッドって無いのかな |
|
swcも同様の仕組みだけどしゅいろ的にはオーバーヘッドがあるように見えている？ |
|
なんか何度か貼った気もするけどともかく Node.js 上で呼び出してベンチマークを取っている |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@syuilo 純粋な呼び出しコストとしてはこんな感じ https://napi-rs.github.io/napi-rs/dev/bench/ |
|
書き忘れてたけどモジュールの件は解決したので ready for review です |
|
👍🏻 |
sasagar
pushed a commit
to sasagar/misskey
that referenced
this pull request
May 9, 2023
* perf: use slacc on check-word-mute when all of specified words are single word * perf: use slacc as possible * build: avoid tarball * chore: update slacc * build: update package name
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
* perf: use slacc on check-word-mute when all of specified words are single word * perf: use slacc as possible * build: avoid tarball * chore: update slacc * build: update package name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ワードミュート検知で単一の単語クエリに https://github.com/misskey-dev/slacc を使用して高速化する
Why
Close #10715
Additional info (optional)
Checklist